fix(ngcc): cope with packages following APF v14+ #45833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
type: bug/fix
state: WIP
comp: ngcc
target: minor
|
You can preview cda0f67 at https://pr45833-cda0f67.ngbuilds.io/. |
gkalpak
changed the title
gkalpak
force-pushed
the
fix-ngcc-apf-v14
branch
from
cda0f67
to
c92207d
Compare
|
You can preview c92207d at https://pr45833-c92207d.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-ngcc-apf-v14
branch
from
c92207d
to
330569e
Compare
|
You can preview 330569e at https://pr45833-330569e.ngbuilds.io/. |
|
You can preview 7c75b0b at https://pr45833-7c75b0b.ngbuilds.io/. |
gkalpak
added a commit
to gkalpak/ngcc-validation
that referenced
this pull request
May 3, 2022
gkalpak
added a commit
to gkalpak/ngcc-validation
that referenced
this pull request
May 3, 2022
|
You can preview 1ab8b94 at https://pr45833-1ab8b94.ngbuilds.io/. |
|
You can preview d4c3a78 at https://pr45833-d4c3a78.ngbuilds.io/. |
gkalpak
added a commit
to gkalpak/ngcc-validation
that referenced
this pull request
May 3, 2022
gkalpak
added
action: review
Remove some unused dependencies from `ngcc` source code.
Move the `loadPackageJson()` helper (and associated generic types, such as `JsonObject`) from `packages/entry_point.ts` to `utils.ts` and also rename it to `loadJson()`. This way, they can be used in other places in future commits, without introducing cyclical dependencies.
In PR angular#45405, the Angular Package Format (APF) was updated so that secondary entry-points (such as `@angular/common/http`) do not have their own `package.json` file, as they used to. Instead, the paths to their various formats and types are exposed via the primary `package.json` file's `exports` property. As an example, see the v13 [@angular/common/http/package.json][1] and compare it with the v14 [@angular/common/package.json > exports][2]. Previously, `ngcc` was not able to analyze such v14+ entry-points and would instead error as it considered such entry-points missing. This commit addresses the issue by detecting this situation and synthesizing a `package.json` file for the secondary entry-points based on the `exports` property of the primary `package.json` file. This data is only used by `ngcc` in order to determine that the entry-point does not need further processing, since it is already in Ivy format. [1]: https://unpkg.com/browse/@angular/common@13.3.5/http/package.json [2]: https://unpkg.com/browse/@angular/common@14.0.0-next.15/package.json
JoostK
added
target: rc
|
You can preview 3686a06 at https://pr45833-3686a06.ngbuilds.io/. |
gkalpak
added
action: merge
|
This PR was merged into the repository by commit d4e949f. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 6, 2022
…ts` (#45833) Move the `loadPackageJson()` helper (and associated generic types, such as `JsonObject`) from `packages/entry_point.ts` to `utils.ts` and also rename it to `loadJson()`. This way, they can be used in other places in future commits, without introducing cyclical dependencies. PR Close #45833
AndrewKushnir
pushed a commit
that referenced
this pull request
May 6, 2022
In PR #45405, the Angular Package Format (APF) was updated so that secondary entry-points (such as `@angular/common/http`) do not have their own `package.json` file, as they used to. Instead, the paths to their various formats and types are exposed via the primary `package.json` file's `exports` property. As an example, see the v13 [@angular/common/http/package.json][1] and compare it with the v14 [@angular/common/package.json > exports][2]. Previously, `ngcc` was not able to analyze such v14+ entry-points and would instead error as it considered such entry-points missing. This commit addresses the issue by detecting this situation and synthesizing a `package.json` file for the secondary entry-points based on the `exports` property of the primary `package.json` file. This data is only used by `ngcc` in order to determine that the entry-point does not need further processing, since it is already in Ivy format. [1]: https://unpkg.com/browse/@angular/common@13.3.5/http/package.json [2]: https://unpkg.com/browse/@angular/common@14.0.0-next.15/package.json PR Close #45833
AndrewKushnir
pushed a commit
that referenced
this pull request
May 6, 2022
Remove some unused dependencies from `ngcc` source code. PR Close #45833
AndrewKushnir
pushed a commit
that referenced
this pull request
May 6, 2022
…ts` (#45833) Move the `loadPackageJson()` helper (and associated generic types, such as `JsonObject`) from `packages/entry_point.ts` to `utils.ts` and also rename it to `loadJson()`. This way, they can be used in other places in future commits, without introducing cyclical dependencies. PR Close #45833
AndrewKushnir
pushed a commit
that referenced
this pull request
May 6, 2022
In PR #45405, the Angular Package Format (APF) was updated so that secondary entry-points (such as `@angular/common/http`) do not have their own `package.json` file, as they used to. Instead, the paths to their various formats and types are exposed via the primary `package.json` file's `exports` property. As an example, see the v13 [@angular/common/http/package.json][1] and compare it with the v14 [@angular/common/package.json > exports][2]. Previously, `ngcc` was not able to analyze such v14+ entry-points and would instead error as it considered such entry-points missing. This commit addresses the issue by detecting this situation and synthesizing a `package.json` file for the secondary entry-points based on the `exports` property of the primary `package.json` file. This data is only used by `ngcc` in order to determine that the entry-point does not need further processing, since it is already in Ivy format. [1]: https://unpkg.com/browse/@angular/common@13.3.5/http/package.json [2]: https://unpkg.com/browse/@angular/common@14.0.0-next.15/package.json PR Close #45833
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #45405, the Angular Package Format (APF) was updated so that secondary entry-points (such as
@angular/common/http) do not have their ownpackage.jsonfile, as they used to. Instead, the paths to their various formats and types are exposed via the primarypackage.jsonfile'sexportsproperty. As an example, see the v13 @angular/common/http/package.json and compare it with the v14 @angular/common/package.json > exports.Previously,
ngccwas not able to analyze such v14+ entry-points and would instead error as it considered such entry-points missing.This commit addresses the issue by detecting this situation and synthesizing a
package.jsonfile for the secondary entry-points based on theexportsproperty of the primarypackage.jsonfile. This data is only used byngccin order to determine that the entry-point does not need further processing, since it is already in Ivy format.FYI, I have tested this on
ngcc-validationand it makes CI green: CI run