fix(core): improve multiple components match error #45645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
state: WIP
area: core
AndrewKushnir
changed the title
AndrewKushnir
force-pushed
the
multiple-comp-error
branch
from
ba3f304
to
67c625c
Compare
AndrewKushnir
changed the title
AndrewKushnir
added
action: review
This commit improves the error message that is thrown at runtime when multiple components match the same element. Now the error message contains names of classes that represent those components.
AndrewKushnir
force-pushed
the
multiple-comp-error
branch
from
67c625c
to
750a5d0
Compare
AndrewKushnir
removed
the
action: review
AndrewKushnir
added
action: presubmit
|
This PR was merged into the repository by commit c6e0e3f. |
dylhunn
pushed a commit
that referenced
this pull request
Apr 15, 2022
This commit improves the error message that is thrown at runtime when multiple components match the same element. Now the error message contains names of classes that represent those components. PR Close #45645
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Apr 25, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.3.3/13.3.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.3.3/13.3.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.3.3/13.3.4) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.3.3/13.3.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.3.3/13.3.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.3.3/13.3.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.3.3/13.3.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.3.3/13.3.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v13.3.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1334-2022-04-20) [Compare Source](angular/angular@13.3.3...13.3.4) ##### core | Commit | Type | Description | | -- | -- | -- | | [9317f513d5](angular/angular@9317f51) | fix | better error message when directive extends a component ([#​45658](angular/angular#45658)) | | [4766817f02](angular/angular@4766817) | fix | improve multiple components match error ([#​45645](angular/angular#45645)) | ##### language-service | Commit | Type | Description | | -- | -- | -- | | [d68333e508](angular/angular@d68333e) | fix | two-way binding completion should not remove the trailing quote ([#​45582](angular/angular#45582)) | #### Special Thanks Andrew Kushnir, Andrew Scott, George Kalpakas, Ilya Marchik, Jeremy Elbourn, Kristiyan Kostadinov, Louis Gombert, Mangalraj, Marko Kaznovac, Paul Gschwendtner, Saurabh Kamble, dario-piotrowicz and ivanwonder <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1316 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the error message that is thrown at runtime when multiple components match the same element. Now the error message contains names of classes that represent those components.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?