Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-service): two-way binding completion should not remove t… #45582

Closed
wants to merge 1 commit into from
Closed

fix(language-service): two-way binding completion should not remove t… #45582

wants to merge 1 commit into from

Commits on Apr 15, 2022

  1. fix(language-service): two-way binding completion should not remove t… 

    …he trailing quote

We allow the path to contain both the `t.BoundAttribute` and `t.BoundEvent` for two-way
bindings but do not want the path to contain both the `t.BoundAttribute` with its
children when the position is in the value span because we would then logically create a path
that also contains the `PropertyWrite` from the `t.BoundEvent`. This early return condition
ensures we target just `t.BoundAttribute` for this case and exclude `t.BoundEvent` children.

Fixes angular/vscode-ng-language-service#1626
    @ivanwonder
    ivanwonder committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    af58ff8 View commit details
    Browse the repository at this point in the history