fix(compiler): avoid errors with extremely long instruction chains #45574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
Our logic for generating code from an AST uses recursion which limits the number of expressions we can nest before we reach the call stack limit. These changes add a limit in order to avoid errors in some cases where the chains become extremely long. Fixes angular#45564.
crisbeto
force-pushed
the
45564/max-chain-length
branch
from
b0fc27b
to
b6667a3
Compare
alxhub
approved these changes
Apr 13, 2022
crisbeto
added
action: merge
|
Merge assistance: I'm away the next few days so I can't run my own presubmit. Feel free to either run one so this change doesn't clog up the PR queue or I'll run it when I get back. |
jessicajaniuk
removed
action: presubmit
|
This PR was merged into the repository by commit 598b759. |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Apr 19, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.3.2/13.3.3) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.3.2/13.3.3) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.3.2/13.3.3) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.3.2/13.3.3) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.3.2/13.3.3) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.3.2/13.3.3) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.3.2/13.3.3) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.3.2/13.3.3) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v13.3.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1333-2022-04-13) [Compare Source](angular/angular@13.3.2...13.3.3) ##### compiler | Commit | Type | Description | | -- | -- | -- | | [e50fd9ee87](angular/angular@e50fd9e) | fix | avoid errors with extremely long instruction chains ([#​45574](angular/angular#45574)) | #### Special Thanks 4javier, Andrew Kushnir, Cédric Exbrayat, Dylan Hunn, George Kalpakas, Hossein Mousavi, Jason Hendee, Joe Martin (Crowdstaffing), Kristiyan Kostadinov, Michael-Doner, Michal Materowski and Virginia Dooley <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1304 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logic for generating code from an AST uses recursion which limits the number of expressions we can nest before we reach the call stack limit. These changes add a limit in order to avoid errors in some cases where the chains become extremely long.
Fixes #45564.