Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): remove deprecated aotSummaries fields in TestBed config #45487

Closed
wants to merge 1 commit into from
Closed

refactor(core): remove deprecated aotSummaries fields in TestBed config #45487

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

BREAKING CHANGE:

Since Ivy, TestBed doesn't use AOT summaries. The aotSummaries fields in TestBed APIs were present, but unused. The fields were deprecated in previous major version and in v14 those fields are removed. The aotSummaries fields were completely unused, so you can just drop them from the TestBed APIs usage.

PR Type

What kind of change does this PR introduce?

  • Other: removal of deprecated API

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added state: WIP target: major This PR is targeted for the next major release flag: deprecation labels Mar 31, 2022
@AndrewKushnir
Copy link
Contributor Author

Initial presubmit.

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: testing Issues related to Angular testing features, such as TestBed area: core Issues related to the framework runtime and removed state: WIP labels Mar 31, 2022
@ngbot ngbot bot modified the milestone: Backlog Mar 31, 2022
@AndrewKushnir AndrewKushnir marked this pull request as ready for review March 31, 2022 04:48
@pullapprove pullapprove bot requested review from gkalpak and jelbourn March 31, 2022 04:48
@AndrewKushnir
refactor(core): remove deprecated aotSummaries fields in TestBed co…
bca74ea 
…nfig

BREAKING CHANGE:

Since Ivy, TestBed doesn't use AOT summaries. The `aotSummaries` fields in TestBed APIs were present, but unused. The fields were deprecated in previous major version and in v14 those fields are removed. The `aotSummaries` fields were completely unused, so you can just drop them from the TestBed APIs usage.
alxhub
alxhub approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

atscott
atscott approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

dylhunn
dylhunn approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2022
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

josephperrott
josephperrott approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Apr 12, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 9add714.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@alxhub alxhub alxhub approved these changes

@dylhunn dylhunn dylhunn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: testing Issues related to Angular testing features, such as TestBed target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndrewKushnir @jessicajaniuk @atscott @alxhub @dylhunn @josephperrott