fix(forms): _reduceValue arrow function now has correct types.
#44483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylhunn
added
area: forms
target: patch
dylhunn
added
action: review
I previously strengthened some weak types in angular#44370. One of these fixes exposed an incorrect call into `_reduceChildren` from `_reduceValue`. This was caught in google3 by a caller who was extending `FormGroup` and overriding these methods. Special thanks to Bart G for catching this issue and suggesting a fix.
dylhunn
force-pushed
the
typings-error-reduce
branch
from
4fff3f6
to
879dca0
Compare
AndrewKushnir
approved these changes
Dec 15, 2021
|
Rerunning failures reveals these are flakes, as most of the targets go green: https://test.corp.google.com/OCL:416417012:BASE:416422956:1639528317533:31818db4 |
dylhunn
added
action: merge
|
This PR was merged into the repository by commit 6a0dadf. |
alxhub
pushed a commit
that referenced
this pull request
Dec 15, 2021
) I previously strengthened some weak types in #44370. One of these fixes exposed an incorrect call into `_reduceChildren` from `_reduceValue`. This was caught in google3 by a caller who was extending `FormGroup` and overriding these methods. Special thanks to Bart G for catching this issue and suggesting a fix. PR Close #44483
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this pull request
Dec 28, 2021
…ular#44483) I previously strengthened some weak types in angular#44370. One of these fixes exposed an incorrect call into `_reduceChildren` from `_reduceValue`. This was caught in google3 by a caller who was extending `FormGroup` and overriding these methods. Special thanks to Bart G for catching this issue and suggesting a fix. PR Close angular#44483
This was referenced Jan 1, 2022
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously strengthened some weak types in #44370. One of these fixes exposed an incorrect call into
_reduceChildrenfrom_reduceValue. This was caught in google3 by a caller who was extendingFormGroupand overriding these methods.Special thanks to Bart G for catching this issue and suggesting a fix.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The type of the callback in
_reduceValueis incorrect, causing warnings for some users in google3.Issue Number: N/A
What is the new behavior?
The type of the callback is fixed.
Does this PR introduce a breaking change?
Other information