Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): Fix a minor error: pendingValue is a value, not a boolean flag. #44450

Closed
wants to merge 1 commit into from

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Dec 12, 2021

Fix a minor error: pendingValue is a value, not a boolean flag.

The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

_pendingValue has the wrong type. This is an internal-only type with no consequences.

Issue Number: N/A

What is the new behavior?

_pendingValue has the right type (any).

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer area: forms target: patch This PR is targeted for the next patch release labels Dec 12, 2021
@ngbot ngbot bot added this to the Backlog milestone Dec 12, 2021
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍪

@dylhunn dylhunn removed the request for review from AndrewKushnir December 13, 2021 17:47
@dylhunn dylhunn added action: presubmit The PR is in need of a google3 presubmit type: bug/fix and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 13, 2021
@dylhunn
Copy link
Contributor Author

dylhunn commented Dec 13, 2021

… is a value not a boolean flag.

The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless.
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Dec 13, 2021
@dylhunn dylhunn removed the request for review from AndrewKushnir December 13, 2021 20:09
@alxhub
Copy link
Member

alxhub commented Dec 14, 2021

This PR was merged into the repository by commit 815d4ce.

alxhub pushed a commit that referenced this pull request Dec 14, 2021
… is a value not a boolean flag. (#44450)

The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless.

PR Close #44450
@alxhub alxhub closed this in 815d4ce Dec 14, 2021
@dylhunn dylhunn deleted the typings-error branch December 14, 2021 23:06
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
… is a value not a boolean flag. (angular#44450)

The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless.

PR Close angular#44450
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: forms target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants