-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(forms): Fix a minor error: pendingValue is a value, not a boolean flag. #44450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍪
Running presubmit: http://test/OCL:416066118:BASE:416066148:1639417585696:e732db0f |
d2e4135
to
ff9de4f
Compare
… is a value not a boolean flag. The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless.
ff9de4f
to
a4394f2
Compare
This PR was merged into the repository by commit 815d4ce. |
… is a value not a boolean flag. (angular#44450) The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless. PR Close angular#44450
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix a minor error: pendingValue is a value, not a boolean flag.
The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
_pendingValue
has the wrong type. This is an internal-only type with no consequences.Issue Number: N/A
What is the new behavior?
_pendingValue
has the right type (any
).Does this PR introduce a breaking change?
Other information