fix(ngcc): correctly resolve UMD dependencies #44381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when processing UMD, ngcc assumed that the `exports` argument of the CommonJS factory call (if present) would be the first argument of the call. This is generally true for the supported UMD formats, but can change if ngcc prepends more imports (and thus factory arguments) while processing the module. This could lead to errors when trying to collect dependencies of an already processed module. (This was accidentally broken in angular#44245 (commit 2bc3522).) This commit fixes it by not making any assumptions about the position of an `exports` argument in the CommonJS factory call. Fixes angular#44380
gkalpak
added
type: bug/fix
target: patch
|
You can preview 86d5c2e at https://pr44381-86d5c2e.ngbuilds.io/. |
gkalpak
added
the
action: review
JoostK
reviewed
Dec 5, 2021
JoostK
approved these changes
Dec 6, 2021
|
You can preview 74d122d at https://pr44381-74d122d.ngbuilds.io/. |
gkalpak
added
action: merge
|
This PR was merged into the repository by commit 4126591. |
alxhub
pushed a commit
that referenced
this pull request
Dec 7, 2021
Previously, when processing UMD, ngcc assumed that the `exports` argument of the CommonJS factory call (if present) would be the first argument of the call. This is generally true for the supported UMD formats, but can change if ngcc prepends more imports (and thus factory arguments) while processing the module. This could lead to errors when trying to collect dependencies of an already processed module. (This was accidentally broken in #44245 (commit 2bc3522).) This commit fixes it by not making any assumptions about the position of an `exports` argument in the CommonJS factory call. Fixes #44380 PR Close #44381
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this pull request
Dec 28, 2021
Previously, when processing UMD, ngcc assumed that the `exports` argument of the CommonJS factory call (if present) would be the first argument of the call. This is generally true for the supported UMD formats, but can change if ngcc prepends more imports (and thus factory arguments) while processing the module. This could lead to errors when trying to collect dependencies of an already processed module. (This was accidentally broken in angular#44245 (commit 2bc3522).) This commit fixes it by not making any assumptions about the position of an `exports` argument in the CommonJS factory call. Fixes angular#44380 PR Close angular#44381
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when processing UMD, ngcc assumed that the
exportsargument of the CommonJS factory call (if present) would be the first argument of the call. This is generally true for the supported UMD formats, but can change if ngcc prepends more imports (and thus factory arguments) while processing the module. This could lead to errors when trying to collect dependencies of an already processed module.(This was accidentally broken in #44245 (commit 2bc3522).)
This commit fixes it by not making any assumptions about the position of an
exportsargument in the CommonJS factory call.Fixes #44380.