Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add migration to remove entryComponents #44322

Closed
wants to merge 1 commit into from
Closed

feat(core): add migration to remove entryComponents #44322

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 1, 2021

This is a resubmit of #44308.

Adds an automated migration that will drop any usages of entryComponents from @NgModule and @Component.

@crisbeto
feat(core): add migration to remove entryComponents
8ff8045 
Adds an automated migration that will drop any usages of `entryComponents` from `@NgModule` and `@Component`.
@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@crisbeto crisbeto added this to the v13.1 milestone Dec 1, 2021
@ngbot ngbot bot removed this from the v13.1 milestone Dec 1, 2021
@crisbeto crisbeto marked this pull request as ready for review December 1, 2021 08:35
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release labels Dec 1, 2021
@ngbot ngbot bot modified the milestone: Backlog Dec 1, 2021
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 1, 2021
@dylhunn
Copy link
Contributor

dylhunn commented Dec 1, 2021

Since this is a resubmit of a rollback, I will go ahead and merge without waiting on pullapprove.

@dylhunn
Copy link
Contributor

dylhunn commented Dec 1, 2021

This PR was merged into the repository by commit e65a245.

@dylhunn dylhunn closed this in e65a245 Dec 1, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
@crisbeto @dimakuba
feat(core): add migration to remove entryComponents (angular#44322)
f80ddb5 
Adds an automated migration that will drop any usages of `entryComponents` from `@NgModule` and `@Component`.

PR Close angular#44322
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@Manndung75 Manndung75 Manndung75 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @dylhunn @devversion @Manndung75