fix(router): prevent componentless routes from being detached #44240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carlosamouco
changed the title
Carlosamouco
changed the title
atscott
approved these changes
Nov 22, 2021
Carlosamouco
force-pushed
the
router-reuse-strategy-detach-fix
branch
from
84e86eb
to
6fe7832
Compare
Currently, when deactivating a route, the detach method of the RouteReuseStrategy is always called even when we are dealing with a componentless route. If when using a custom strategy we attempt to detach a componentless route, an exception is thrown causing the navigation to break. This change prevents this from happening, by not triggering the detach of the route reuse strategy. Fixes angular#44239
Carlosamouco
force-pushed
the
router-reuse-strategy-detach-fix
branch
from
6fe7832
to
3e481f8
Compare
atscott
added
target: patch
atscott
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
merge assistance: saucelabs failure looks unrelated |
|
This PR was merged into the repository by commit f44cb57. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 23, 2021
Currently, when deactivating a route, the detach method of the RouteReuseStrategy is always called even when we are dealing with a componentless route. If when using a custom strategy we attempt to detach a componentless route, an exception is thrown causing the navigation to break. This change prevents this from happening, by not triggering the detach of the route reuse strategy. Fixes #44239 PR Close #44240
|
Is there an ETA for |
|
@sventropy This week Wednesday (Dec. 1) |
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this pull request
Dec 28, 2021
…r#44240) Currently, when deactivating a route, the detach method of the RouteReuseStrategy is always called even when we are dealing with a componentless route. If when using a custom strategy we attempt to detach a componentless route, an exception is thrown causing the navigation to break. This change prevents this from happening, by not triggering the detach of the route reuse strategy. Fixes angular#44239 PR Close angular#44240
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, when deactivating a route, the detach method of the RouteReuseStrategy is always called
even when we are dealing with a componentless route. If when using a custom strategy we attempt to
detach a componentless route, an exception is thrown causing the navigation to break.
Issue Number: #44239
What is the new behavior?
When deactivating a componentless route, we prevent the detach method of the route reuse strategy from being called.
Does this PR introduce a breaking change?
Other information