fix(compiler-cli): ensure that ngcc does not write a lock-file into node_modules package directories #44228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
action: review
alan-agius4
reviewed
Nov 19, 2021
petebacondarwin
force-pushed
the
ngcc-move-lockfile
branch
from
f7cd842
to
e9c0e57
Compare
alan-agius4
reviewed
Nov 21, 2021
| const moduleConstructor: any = module.constructor; | ||
| const originalResolveFileName = moduleConstructor._resolveFilename; | ||
| spyOn<any>(moduleConstructor, '_resolveFilename').and.callFake(function(request: string) { | ||
| if (request === '@angular/compiler-cli/package.json') { |
There was a problem hiding this comment.
Can use a ternary here!
alan-agius4
approved these changes
Nov 21, 2021
petebacondarwin
added
action: merge
petebacondarwin
requested review from
josephperrott
and removed request for
IgorMinar
petebacondarwin
added
the
action: review
JoostK
approved these changes
Nov 21, 2021
…les package directories When executing, ngcc writes a lock-file that is used to coordinate multiple concurrent instances of ngcc. Previously, this file was written at `node_modules/@angular/compiler-cli/ngcc`, or similar depending upon the bundling of the package. But this causes problems for setups where `node_modules` package directories are expected to be read-only. Now, the lock-file is written as `.ngcc_lock_file` into the top of the `node_modules`, which is an acceptable place to store transient files. This change should help to unblock use of tools like pnpm and lerna, which can use symlinks to readonly package directories.
…de_modules package directories
petebacondarwin
force-pushed
the
ngcc-move-lockfile
branch
from
e9c0e57
to
48a610c
Compare
petebacondarwin
removed
the
action: review
|
This PR was merged into the repository by commit 24b6353. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 22, 2021
…les package directories (#44228) When executing, ngcc writes a lock-file that is used to coordinate multiple concurrent instances of ngcc. Previously, this file was written at `node_modules/@angular/compiler-cli/ngcc`, or similar depending upon the bundling of the package. But this causes problems for setups where `node_modules` package directories are expected to be read-only. Now, the lock-file is written as `.ngcc_lock_file` into the top of the `node_modules`, which is an acceptable place to store transient files. This change should help to unblock use of tools like pnpm and lerna, which can use symlinks to readonly package directories. PR Close #44228
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this pull request
Dec 28, 2021
…les package directories (angular#44228) When executing, ngcc writes a lock-file that is used to coordinate multiple concurrent instances of ngcc. Previously, this file was written at `node_modules/@angular/compiler-cli/ngcc`, or similar depending upon the bundling of the package. But this causes problems for setups where `node_modules` package directories are expected to be read-only. Now, the lock-file is written as `.ngcc_lock_file` into the top of the `node_modules`, which is an acceptable place to store transient files. This change should help to unblock use of tools like pnpm and lerna, which can use symlinks to readonly package directories. PR Close angular#44228
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing, ngcc writes a lock-file that is used to coordinate multiple concurrent instances of ngcc.
Previously, this file was written at
node_modules/@angular/compiler-cli/ngcc, or similar depending upon the bundling of the package.But this causes problems for setups where
node_modulespackage directories are expected to be read-only.Now, the lock-file is written as
.ngcc_lock_fileinto the top of thenode_modules, which is an acceptable place to store transient files.This change should help to unblock use of tools like pnpm and lerna, which can use symlinks to readonly package directories.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information