Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): make the FormControlStatus available as a public API #44183

Closed
wants to merge 1 commit into from
Closed

fix(forms): make the FormControlStatus available as a public API #44183

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit makes the FormControlStatus symbol available as a public API. The symbol itself
was intended to become a part of the public API, but due to the missing re-export, the symbol
remains private.

Fixes #44176.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
fix(forms): make the FormControlStatus available as a public API
7ae610c 
This commit makes the `FormControlStatus` symbol available as a public API. The symbol itself
was intended to become a part of the public API, but due to the missing re-export, the symbol
remains private.

Fixes angular#44176.
@AndrewKushnir AndrewKushnir added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: forms target: patch This PR is targeted for the next patch release labels Nov 15, 2021
@google-cla google-cla bot added the cla: yes label Nov 15, 2021
@ngbot ngbot bot modified the milestone: Backlog Nov 15, 2021
@AndrewKushnir AndrewKushnir mentioned this pull request Nov 15, 2021
Closed
@dylhunn
Copy link
Contributor

dylhunn commented Nov 16, 2021

Thanks for fixing this. LGTM

@dylhunn
Copy link
Contributor

dylhunn commented Nov 16, 2021

reviewed-for: public-api

atscott
atscott approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

petebacondarwin
petebacondarwin approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from dylhunn November 16, 2021 22:15
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 16, 2021
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Nov 17, 2021
@ngbot
Copy link

ngbot bot commented Nov 17, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    pending status "pullapprove" is pending
    pending missing required status "cla/google"
    pending 5 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir
Copy link
Contributor Author

This PR was merged into the repository by commit 38c02e1.

AndrewKushnir added a commit that referenced this pull request Nov 17, 2021
@AndrewKushnir
fix(forms): make the FormControlStatus available as a public API (#…
96fedd2 
…44183)

This commit makes the `FormControlStatus` symbol available as a public API. The symbol itself
was intended to become a part of the public API, but due to the missing re-export, the symbol
remains private.

Fixes #44176.

PR Close #44183
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
@AndrewKushnir @dimakuba
fix(forms): make the FormControlStatus available as a public API (a…
8142c55 
…ngular#44183)

This commit makes the `FormControlStatus` symbol available as a public API. The symbol itself
was intended to become a part of the public API, but due to the missing re-export, the symbol
remains private.

Fixes angular#44176.

PR Close angular#44183
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonukapoor sonukapoor sonukapoor approved these changes

@atscott atscott atscott approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

@jelbourn jelbourn Awaiting requested review from jelbourn

@zarend zarend Awaiting requested review from zarend

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

@dylhunn dylhunn Awaiting requested review from dylhunn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: forms cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Unable into import FormControlStatus
5 participants
@AndrewKushnir @dylhunn @petebacondarwin @sonukapoor @atscott