fix(compiler-cli): handle pre-release versions when checking version #44109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
ts-version-check
branch
from
3dec83c
to
e96f165
Compare
alan-agius4
reviewed
Nov 8, 2021
crisbeto
added
action: review
crisbeto
changed the title
devversion
reviewed
Nov 8, 2021
crisbeto
force-pushed
the
ts-version-check
branch
from
e96f165
to
2a223dd
Compare
JoostK
approved these changes
Nov 9, 2021
Currently the TS version checking function interprets a version like `1.2.3-rc.5` as `1.2.NaN` which would allow it to bypass the version checking altogether. These changes add a little bit more logic to ensure that such versions are handled correctly. There's also an error if we don't manage to parse the version string. Also it seemed like we never actually ran the version check unit tests, because they didn't have a test target.
crisbeto
force-pushed
the
ts-version-check
branch
from
2a223dd
to
9d2e6f5
Compare
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 247c18d. |
atscott
pushed a commit
that referenced
this pull request
Nov 9, 2021
…44109) Currently the TS version checking function interprets a version like `1.2.3-rc.5` as `1.2.NaN` which would allow it to bypass the version checking altogether. These changes add a little bit more logic to ensure that such versions are handled correctly. There's also an error if we don't manage to parse the version string. Also it seemed like we never actually ran the version check unit tests, because they didn't have a test target. PR Close #44109
This was referenced Dec 1, 2021
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this pull request
Dec 28, 2021
…ngular#44109) Currently the TS version checking function interprets a version like `1.2.3-rc.5` as `1.2.NaN` which would allow it to bypass the version checking altogether. These changes add a little bit more logic to ensure that such versions are handled correctly. There's also an error if we don't manage to parse the version string. Also it seemed like we never actually ran the version check unit tests, because they didn't have a test target. PR Close angular#44109
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the TS version checking function interprets a version like
1.2.3-rc.5as1.2.NaNwhich would allow it to bypass the version checking altogether.These changes add a little bit more logic to ensure that such versions are handled correctly. There's also an error if we don't manage to parse the version string.
Also it seemed like we never actually ran the version check unit tests, because they didn't have a test target.