Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: deprecate factory-based signature of the downgradeModule function #44090

Closed
wants to merge 2 commits into from
Closed

docs: deprecate factory-based signature of the downgradeModule function #44090

wants to merge 2 commits into from

Conversation

AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Nov 5, 2021 •
edited

DEPRECATED:

The downgradeModule function calls with NgModule factories are deprecated. Please use NgModule class based downgradeModule calls instead.

Note: this PR also contains a commit from @petebacondarwin to ensure overloaded functions render correctly.

PR Type

What kind of change does this PR introduce?

  • Other... Please describe: deprecation of an old API.

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added state: WIP area: upgrade Issues related to AngularJS → Angular upgrade APIs target: minor This PR is targeted for the next minor release labels Nov 5, 2021
@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@ngbot ngbot bot modified the milestone: Backlog Nov 5, 2021
@mary-poppins
Copy link

You can preview 50f01bc at https://pr44090-50f01bc.ngbuilds.io/.

@google-cla
Copy link

google-cla bot commented Nov 9, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 9, 2021
@petebacondarwin
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 9, 2021
@mary-poppins
Copy link

You can preview 8b68842 at https://pr44090-8b68842.ngbuilds.io/.

@AndrewKushnir AndrewKushnir force-pushed the deprecate-downgrademodule-with-ngfactory branch from 8b68842 to e7e711d Compare November 9, 2021 17:33
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Nov 9, 2021
@AndrewKushnir AndrewKushnir marked this pull request as ready for review November 9, 2021 17:35
@mary-poppins
Copy link

You can preview e7e711d at https://pr44090-e7e711d.ngbuilds.io/.

gkalpak
gkalpak approved these changes Nov 15, 2021
View reviewed changes
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 15, 2021
AndrewKushnir and others added 2 commits November 15, 2021 18:27
@AndrewKushnir
docs: deprecate factory-based signature of the downgradeModule func…
674173a 
…tion

DEPRECATED:

The `downgradeModule` function calls with NgModule factories are deprecated. Please use NgModule class based `downgradeModule` calls instead.
@petebacondarwin @AndrewKushnir
build(docs-infra): ensure overloaded functions render correctly
3885368 
If there were 1 or 2 additional overloads on a free-standing function in the API the overloads were not being shown.

Also the type of overload parameters were not being escaped correctly.
@AndrewKushnir AndrewKushnir force-pushed the deprecate-downgrademodule-with-ngfactory branch from e7e711d to 3885368 Compare November 16, 2021 02:27
@AndrewKushnir AndrewKushnir removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 16, 2021
@mary-poppins
Copy link

You can preview 3885368 at https://pr44090-3885368.ngbuilds.io/.

jelbourn
jelbourn approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

atscott
atscott approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from jelbourn November 16, 2021 20:15
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Nov 16, 2021
@ngbot
Copy link

ngbot bot commented Nov 17, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    pending status "pullapprove" is pending
    pending missing required status "cla/google"
    pending 4 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

petebacondarwin
petebacondarwin approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

jessicajaniuk
jessicajaniuk approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍪

reviewed-for: public-api

@AndrewKushnir
Copy link
Contributor Author

This PR was merged into the repository by commit e0c7360.

AndrewKushnir pushed a commit that referenced this pull request Nov 17, 2021
@petebacondarwin @AndrewKushnir
build(docs-infra): ensure overloaded functions render correctly (#44090)
e0c7360 
If there were 1 or 2 additional overloads on a free-standing function in the API the overloads were not being shown.

Also the type of overload parameters were not being escaped correctly.

PR Close #44090
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
@AndrewKushnir @dimakuba
docs: deprecate factory-based signature of the downgradeModule func…
f9c98d3 
…tion (angular#44090)

DEPRECATED:

The `downgradeModule` function calls with NgModule factories are deprecated. Please use NgModule class based `downgradeModule` calls instead.

PR Close angular#44090
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
@petebacondarwin @dimakuba
build(docs-infra): ensure overloaded functions render correctly (angu…
cfee22a 
…lar#44090)

If there were 1 or 2 additional overloads on a free-standing function in the API the overloads were not being shown.

Also the type of overload parameters were not being escaped correctly.

PR Close angular#44090
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@atscott atscott atscott approved these changes

@gkalpak gkalpak gkalpak approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

@dylhunn dylhunn Awaiting requested review from dylhunn

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: upgrade Issues related to AngularJS → Angular upgrade APIs cla: yes target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@AndrewKushnir @mary-poppins @petebacondarwin @atscott @jelbourn @gkalpak @jessicajaniuk