fix(core): add missing info about a component in the "pipe could not be found" error message #44081

rohan-pednekar · 2021-11-05T14:10:19Z

Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: 43855

What is the new behavior?

Before

Currently Angular throws the following error message at runtime when a pipe can not be found. However there is no information on which component has this problem, which makes debugging harder.

The pipe 'testMissingPipe' could not be found!

After

Add error message for pipe with component class name in which it has a problem.

The pipe 'testMissingPipe' could not be found  in the 'TestComponent' component!

Does this PR introduce a breaking change?

Yes
No

Other information

packages/core/src/render3/pipe.ts

AndrewKushnir

@rohan-pednekar thanks for creating this PR! Please see comments below.

packages/core/test/acceptance/pipe_spec.ts

packages/core/src/render3/pipe.ts

AndrewKushnir

Thanks for the updates @rohan-pednekar. The changes look good and we are very close to landing this PR! There are few remaining items:

I've left a comment to move a whitespace in the error message, please have a look
We'd need all commits to be merged into one and let's call it fix(core): add missing info about a component in the "pipe could not be found" error message instead of feat(core): ...
The "lint" CI job indicates that one of the files requires formatting. Could you please rebase this PR on top of the latest master and run the command from the "lint" CI job?
The legacy-unit-tests-saucelabs fails for unrelated reasons: it uses old JIT compiler, thus the error message is different. We are working on fixing that, so there are no extra fixes are needed in this PR to solve that.

Thank you.

packages/core/src/render3/pipe.ts

rohan-pednekar · 2021-11-12T17:23:57Z

Thanks for the updates @rohan-pednekar. The changes look good and we are very close to landing this PR! There are few remaining items:

I've left a comment to move a whitespace in the error message, please have a look

We'd need all commits to be merged into one and let's call it fix(core): add missing info about a component in the "pipe could not be found" error message instead of feat(core): ...

The "lint" CI job indicates that one of the files requires formatting. Could you please rebase this PR on top of the latest master and run the command from the "lint" CI job?

The legacy-unit-tests-saucelabs fails for unrelated reasons: it uses old JIT compiler, thus the error message is different. We are working on fixing that, so there are no extra fixes are needed in this PR to solve that.

Thank you.

Sure. I'll add all the suggested changes. Thank you @AndrewKushnir

AndrewKushnir · 2021-11-16T02:07:32Z

FYI this PR is blocked by #43884 (the lagacy-unit-tests-saucelabs is failing due to VE vs Ivy error message format).

AndrewKushnir

@rohan-pednekar thanks for the updates, the changes look good 👍

I've started tests in Google's codebase and will let you know if there are any issues.

rohan-pednekar · 2021-11-16T04:30:22Z

@rohan-pednekar thanks for the updates, the changes look good 👍

I've started tests in Google's codebase and will let you know if there are any issues.

Thank you @AndrewKushnir

…be found" error message Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle.

AndrewKushnir · 2021-11-24T02:54:05Z

@rohan-pednekar FYI, this PR is now unblocked (after landing #43884) and I've rebased it on top of the most recent version of the master branch. The tests in Google's codebase went well, so the only remaining step is to get one more review. I will take care of it and let you know. Thank you.

rohan-pednekar · 2021-11-24T04:25:58Z

@rohan-pednekar FYI, this PR is now unblocked (after landing #43884) and I've rebased it on top of the most recent version of the master branch. The tests in Google's codebase went well, so the only remaining step is to get one more review. I will take care of it and let you know. Thank you.

Sure. Thank you @AndrewKushnir 👍😊

jessicajaniuk

LGTM 🍪

jessicajaniuk · 2021-11-24T18:57:12Z

This PR was merged into the repository by commit b06e398.

…be found" error message (#44081) Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle. PR Close #44081

AndrewKushnir · 2021-11-24T19:06:49Z

@rohan-pednekar just want to let you know that your PR was merged and the change will be available as a part of the v13.0.3 release (likely next week). Thanks for contributing to Angular! 👍

rohan-pednekar · 2021-11-25T14:56:03Z

@rohan-pednekar just want to let you know that your PR was merged and the change will be available as a part of the v13.0.3 release (likely next week). Thanks for contributing to Angular! 👍

Wow! 😍 Without your help and support, this would not have been possible. Thank you once again @AndrewKushnir ❤.

rohan-pednekar · 2021-11-25T15:02:20Z

Also thanks to @jessicajaniuk, @splincode 👍😊

angular-automatic-lock-bot · 2021-12-26T16:06:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…be found" error message (angular#44081) Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle. PR Close angular#44081

google-cla bot added the cla: yes label Nov 5, 2021

pullapprove bot requested a review from jessicajaniuk November 5, 2021 14:10

splincode reviewed Nov 5, 2021

View reviewed changes

packages/core/src/render3/pipe.ts Show resolved Hide resolved

splincode reviewed Nov 5, 2021

View reviewed changes

packages/core/src/render3/pipe.ts Show resolved Hide resolved

AndrewKushnir self-assigned this Nov 5, 2021

AndrewKushnir reviewed Nov 5, 2021

View reviewed changes

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime core: di hotlist: error messages labels Nov 5, 2021

ngbot bot modified the milestone: Backlog Nov 5, 2021

AndrewKushnir added the target: minor This PR is targeted for the next minor release label Nov 5, 2021

AndrewKushnir mentioned this pull request Nov 9, 2021

Improve the The pipe could not be found error message #43855

Closed

AndrewKushnir reviewed Nov 11, 2021

View reviewed changes

packages/core/src/render3/pipe.ts Outdated Show resolved Hide resolved

rohan-pednekar force-pushed the 43855-improve-pipe-error-message branch from b1e3ce2 to c66b3c7 Compare November 14, 2021 09:27

rohan-pednekar changed the title ~~feat(core): improve the pipe could not be found error message~~ fix(core): add missing info about a component in the "pipe could not be found" error message Nov 14, 2021

rohan-pednekar requested a review from AndrewKushnir November 14, 2021 10:02

AndrewKushnir added state: blocked target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Nov 16, 2021

AndrewKushnir approved these changes Nov 16, 2021

View reviewed changes

AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Nov 16, 2021

AndrewKushnir removed the state: blocked label Nov 24, 2021

fix(core): add missing info about a component in the "pipe could not …

32fc310

…be found" error message Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle.

AndrewKushnir force-pushed the 43855-improve-pipe-error-message branch from c66b3c7 to 32fc310 Compare November 24, 2021 02:50

jessicajaniuk approved these changes Nov 24, 2021

View reviewed changes

jessicajaniuk removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Nov 24, 2021

AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Nov 24, 2021

jessicajaniuk closed this in b06e398 Nov 24, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): add missing info about a component in the "pipe could not be found" error message #44081

fix(core): add missing info about a component in the "pipe could not be found" error message #44081

rohan-pednekar commented Nov 5, 2021 •

edited

AndrewKushnir left a comment

AndrewKushnir left a comment

rohan-pednekar commented Nov 12, 2021

AndrewKushnir commented Nov 16, 2021

AndrewKushnir left a comment •

edited

rohan-pednekar commented Nov 16, 2021

AndrewKushnir commented Nov 24, 2021

rohan-pednekar commented Nov 24, 2021

jessicajaniuk left a comment

jessicajaniuk commented Nov 24, 2021

AndrewKushnir commented Nov 24, 2021

rohan-pednekar commented Nov 25, 2021

rohan-pednekar commented Nov 25, 2021

angular-automatic-lock-bot bot commented Dec 26, 2021

fix(core): add missing info about a component in the "pipe could not be found" error message #44081

fix(core): add missing info about a component in the "pipe could not be found" error message #44081

Conversation

rohan-pednekar commented Nov 5, 2021 • edited

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

AndrewKushnir left a comment

Choose a reason for hiding this comment

AndrewKushnir left a comment

Choose a reason for hiding this comment

rohan-pednekar commented Nov 12, 2021

AndrewKushnir commented Nov 16, 2021

AndrewKushnir left a comment • edited

Choose a reason for hiding this comment

rohan-pednekar commented Nov 16, 2021

AndrewKushnir commented Nov 24, 2021

rohan-pednekar commented Nov 24, 2021

jessicajaniuk left a comment

Choose a reason for hiding this comment

jessicajaniuk commented Nov 24, 2021

AndrewKushnir commented Nov 24, 2021

rohan-pednekar commented Nov 25, 2021

rohan-pednekar commented Nov 25, 2021

angular-automatic-lock-bot bot commented Dec 26, 2021

rohan-pednekar commented Nov 5, 2021 •

edited

AndrewKushnir left a comment •

edited