fix(platform-browser): use correct parent in animation removeChild ca… #44033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good, but the CI flaked. @raman-savitski can you try to push the same commit again so the CI can run? |
…llback Animation's `onRemovalComplete` callback is using incorrect `parentNode`. Should be parentNode provided by `delegate.parentNode(element)` instead of direct `element.parentNode`. This is not a problem with default renderer but can cause problems with custom renderer if it uses another logic to add/remove nodes. Fixes angular#44023
roman-savitski
force-pushed
the
platform-browser_parentNode
branch
from
486cb38
to
472268a
Compare
Done, CI checks passed this time. |
crisbeto
added
action: merge
AndrewKushnir
approved these changes
Nov 9, 2021
AndrewKushnir
added
area: animations
and removed
action: presubmit
|
This PR was merged into the repository by commit 236bdff. |
atscott
pushed a commit
that referenced
this pull request
Nov 10, 2021
…llback (#44033) Animation's `onRemovalComplete` callback is using incorrect `parentNode`. Should be parentNode provided by `delegate.parentNode(element)` instead of direct `element.parentNode`. This is not a problem with default renderer but can cause problems with custom renderer if it uses another logic to add/remove nodes. Fixes #44023 PR Close #44033
This was referenced Dec 1, 2021
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this pull request
Dec 28, 2021
…llback (angular#44033) Animation's `onRemovalComplete` callback is using incorrect `parentNode`. Should be parentNode provided by `delegate.parentNode(element)` instead of direct `element.parentNode`. This is not a problem with default renderer but can cause problems with custom renderer if it uses another logic to add/remove nodes. Fixes angular#44023 PR Close angular#44033
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…llback
Animation's
onRemovalCompletecallback is using incorrectparentNode.Should be parentNode provided by
delegate.parentNode(element)instead of directelement.parentNode.This is not a problem with default renderer but can cause problems with custom renderer if it uses another
logic to add/remove nodes.
Fixes #44023
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 44023
What is the new behavior?
Does this PR introduce a breaking change?
Other information