fix(compiler): do not error if $any is used inside a listener #43866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
JoostK
approved these changes
Oct 17, 2021
JoostK
added
action: merge
|
Shouldn't the commit messages be: or ?? As it is written, it sounds like the aim is to throw an error if |
petebacondarwin
added
the
action: cleanup
Fixes that `$any` casts weren't being converted to statements inside listeners which resulted in a compiler error. Fixes angular#43841.
crisbeto
changed the title
crisbeto
removed
the
action: cleanup
crisbeto
force-pushed
the
43841/any-listener
branch
from
d4be031
to
62f99c5
Compare
AndrewKushnir
added
target: rc
|
This PR was merged into the repository by commit c944fee. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 18, 2021
|
@crisbeto there was a merge conflict with the 12.2.x branch, so this change was merged to 13.0.x and master branches. If the fix needs to be included into 12.2.x branch, could you please create a new PR with the necessary changes? Thank you. |
This was referenced Nov 1, 2021
Closed
build(deps): bump @angular/platform-browser from 12.2.4 to 12.2.12
numbersprotocol/capture-lite#1003
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that
$anycasts weren't being converted to statements inside listeners which resulted in a compiler error.Fixes #43841.