fix(router): Do not clear currentNavigation if already set to next one #43852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: router
target: patch
Experimentation with the Router URL management exposed a situation where the `currentNavigation` was being cleared in the `finalize` after the `currentNavigation` was already set to the next one. This change ensures that the `currentNavigation` is only cleared if the id of the finalized transition matches the one on the `currentNavigation` object.
atscott
force-pushed
the
dontclearcurrentnavigation
branch
from
a845c23
to
fde0e86
Compare
|
This PR was merged into the repository by commit 32f368a. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 18, 2021
#43852) Experimentation with the Router URL management exposed a situation where the `currentNavigation` was being cleared in the `finalize` after the `currentNavigation` was already set to the next one. This change ensures that the `currentNavigation` is only cleared if the id of the finalized transition matches the one on the `currentNavigation` object. PR Close #43852
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 18, 2021
#43852) Experimentation with the Router URL management exposed a situation where the `currentNavigation` was being cleared in the `finalize` after the `currentNavigation` was already set to the next one. This change ensures that the `currentNavigation` is only cleared if the id of the finalized transition matches the one on the `currentNavigation` object. PR Close #43852
This was referenced Nov 1, 2021
build(deps-dev): bump @angular/compiler-cli from 12.2.4 to 12.2.12
numbersprotocol/capture-lite#1018
Closed
Closed
build(deps): bump @angular/platform-browser from 12.2.4 to 12.2.12
numbersprotocol/capture-lite#1003
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Serginho
pushed a commit
to TuLotero/angular
that referenced
this pull request
Jan 20, 2022
angular#43852) Experimentation with the Router URL management exposed a situation where the `currentNavigation` was being cleared in the `finalize` after the `currentNavigation` was already set to the next one. This change ensures that the `currentNavigation` is only cleared if the id of the finalized transition matches the one on the `currentNavigation` object. PR Close angular#43852
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimentation with the Router URL management exposed a situation where
the
currentNavigationwas being cleared in thefinalizeafter thecurrentNavigationwas already set to the next one.This change ensures that the
currentNavigationis only cleared if theid of the finalized transition matches the one on the
currentNavigationobject.