fix(router): fix Router's public API for canceledNavigationResolution #43842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit which made the `canceledNavigationResolution` property on the `Router` public did not add the corresponding configuration in the `ExtraOptions`. angular@3c6b653 This was a mistake and is being corrected in this commit. We should not encourage changing the properties post-setup (i.e. `inject(Router).canceledNavigationResolution = 'computed'`). This manner of configuration makes the options non-tree shakeable because we have to keep both implementations in case the value changes at runtime.
atscott
added
area: router
target: rc
pullapprove
bot
requested review from
AndrewKushnir,
jelbourn,
petebacondarwin and
zarend
AndrewKushnir
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Reviewed-for: public-api
Quick comment: while this change updates public API surface, it does it in a non-breaking way. This is clearly a fix for the API to add a capability to provide canceledNavigationResolution config option, which was missing during the initial implementation of the feature.
petebacondarwin
approved these changes
Oct 14, 2021
jessicajaniuk
approved these changes
Oct 15, 2021
|
This PR was merged into the repository by commit e79e3ca. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 15, 2021
…#43842) The commit which made the `canceledNavigationResolution` property on the `Router` public did not add the corresponding configuration in the `ExtraOptions`. 3c6b653 This was a mistake and is being corrected in this commit. We should not encourage changing the properties post-setup (i.e. `inject(Router).canceledNavigationResolution = 'computed'`). This manner of configuration makes the options non-tree shakeable because we have to keep both implementations in case the value changes at runtime. PR Close #43842
This was referenced Nov 1, 2021
build(deps-dev): bump @angular/compiler-cli from 12.2.4 to 12.2.12
numbersprotocol/capture-lite#1018
Closed
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit which made the
canceledNavigationResolutionproperty on theRouterpublic did not add the corresponding configuration in the
ExtraOptions.3c6b653
This was a mistake and is being corrected in this commit. We should not
encourage changing the properties post-setup (i.e.
inject(Router).canceledNavigationResolution = 'computed'). This mannerof configuration makes the options non-tree shakeable because we have to
keep both implementations in case the value changes at runtime.