fix(compiler-cli): updates ngc to pass the build when only warnings are emitted
#43673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylhunn
added
the
area: compiler
dgp1130
force-pushed
the
ngc-diagnostics
branch
from
17dd41e
to
bdde505
Compare
|
@alxhub is this required for v13 so |
alxhub
requested changes
Oct 5, 2021
Chatted in Slack, the deprecating warning won't make v13 anyways so no need to get this in. |
dgp1130
force-pushed
the
ngc-diagnostics
branch
from
bdde505
to
d3b3da8
Compare
dgp1130
force-pushed
the
ngc-diagnostics
branch
from
d3b3da8
to
0a0a25f
Compare
alxhub
approved these changes
Oct 11, 2021
dgp1130
force-pushed
the
ngc-diagnostics
branch
from
0a0a25f
to
8eb6a56
Compare
… are emitted Refs angular#42966. Previously, a build when emitted one warning and no errors would fail with a non-zero exit code. This is not what users would expect, but had not been an issue before since the compiler did not actually emit any warnings. With upcoming extended template diagnostics and other warnings, this is now a case that needs to be supported. Warnings are printed to `stderr` as before, but `ngc` now exits with code `0` and the build is considered successful. Implemented this by adding a new `expectedExitCode` parameter to `driveDiagnostics()` which asserts against the real exit code. Most importantly, it does not **require** the the build to pass since any exit code can be given, so it is up to the test to assert this as well as many messages printed to make sure they are acceptable. This is useful for testing warnings and ensuring the build still passes.
dgp1130
force-pushed
the
ngc-diagnostics
branch
from
8eb6a56
to
e0a15ef
Compare
AndrewKushnir
added
target: rc
|
This PR was merged into the repository by commit b2b5972. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 15, 2021
… are emitted (#43673) Refs #42966. Previously, a build when emitted one warning and no errors would fail with a non-zero exit code. This is not what users would expect, but had not been an issue before since the compiler did not actually emit any warnings. With upcoming extended template diagnostics and other warnings, this is now a case that needs to be supported. Warnings are printed to `stderr` as before, but `ngc` now exits with code `0` and the build is considered successful. Implemented this by adding a new `expectedExitCode` parameter to `driveDiagnostics()` which asserts against the real exit code. Most importantly, it does not **require** the the build to pass since any exit code can be given, so it is up to the test to assert this as well as many messages printed to make sure they are acceptable. This is useful for testing warnings and ensuring the build still passes. PR Close #43673
|
@dgp1130 there was a merge conflict with the 12.2.x branch, so I merged the change to master and 13.0.x. If this change needs to land in 12.2.x, could you please create a new PR with the necessary changes? Thank you. |
|
@AndrewKushnir, considering |
This was referenced Nov 1, 2021
build(deps-dev): bump @angular/compiler-cli from 12.2.4 to 12.2.12
numbersprotocol/capture-lite#1018
Closed
Closed
This was referenced Nov 1, 2021
build(deps): bump @angular/platform-browser from 12.2.4 to 12.2.12
numbersprotocol/capture-lite#1003
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #42966.
Previously, a build when emitted one warning and no errors would fail with a non-zero exit code. This is not what users would expect, but had not been an issue before since the compiler did not actually emit any warnings. With upcoming extended template diagnostics and other warnings, this is now a case that needs to be supported. Warnings are printed to
stderras before, butngcnow exits with code0and the build is considered successful.Implemented this by adding a new
driveMainWithWarnings()test method which returns the exit code and any messages logged tostderr. Most importantly, it does not require the the build to pass, so it is up to the test to assert this as well as many messages printed to make sure they are acceptable. This is useful for testing warnings and ensuring the build still passes.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #42966.
ngcfails when a compilation returns warnings but no errors. It should succeed as long as no errors are emitted, regardless of any warnings.What is the new behavior?
ngcnow exits with code 0 (passes) when a compilation returns no errors, even if warnings are emitted.Does this PR introduce a breaking change?
The compiler does not currently produce warnings, so there is no change in behavior. This is intended to unblock future compiler changes.
Other information
/cc @atscott.