fix(core): do not use Function constructors in development mode to avoid CSP violations

[JoostK]

This commit removes the dynamic creation of named arrays for internal
runtime storage arrays as they may cause CSP violations in development
mode, when an application's CSP configuration does not include
unsafe-eval.

Named arrays for view data can still be enabled in development mode
using the ngDevMode=namedConstructors query parameter when loading the
application.

The usage of native class syntax for named arrays does not have the
desired effect when the code is downleveled to ES5. Since ES5 targets
are becoming increasingly more rare this is considered less of a problem
than the CSP violation.

Fixes #43494

[JoostK]

For context: ngDevMode.namedConstructors was introduced when the named constructors were added in #30542 but it was actually never used. It is disabled by default:

angular/packages/core/src/util/ng_dev_mode.ts

Lines 54 to 57 in 4610093

	export function ngDevModeResetPerfCounters(): NgDevModePerfCounters {
	const locationString = typeof location !== 'undefined' ? location.toString() : '';
	const newCounters: NgDevModePerfCounters = {
	namedConstructors: locationString.indexOf('ngDevMode=namedConstructors') != -1,

[JoostK]

Note: this is currently always false as our testing infrastructure is using ES5 code.

[IgorMinar]

this looks good to me. thanks @JoostK

[AndrewKushnir]

Presubmit.

[atscott]

This PR was merged into the repository by commit 4f8eaac.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}