Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler-cli): inline resources when generating class metadata calls #43178

Closed
wants to merge 2 commits into from
Closed

feat(compiler-cli): inline resources when generating class metadata calls #43178

wants to merge 2 commits into from

Commits on Aug 17, 2021

  1. feat(compiler-cli): inline resources when generating class metadata c… 

    …alls

Previously with View Engine output, the `enableResourceInlining` option
could be set to inline external templates and styles (also for the
resulting `.metadata.json` files). We want to do the same for the Ivy
compilation pipeline (regardless of the compilation mode). The full
compilation definitions, and partial declarations currently already
inline resources in a way that no external requests need to be made.

Although there is one exception currently. These are the calls for
setting class metadata (for testbed overrides). This commit updates
the set class metadata calls (for both partial and full compilation)
to always inline resources. This means that libraries do not need
to start shipping external styles/templates just for the
`setClassMetadata` calls.

Note: Only doing this for partial compilation has been considered, but
it seems like it would be simpler implementation-wise to do this for
full compilation as well. Given the external resources are already
inlined (through their `ecmp` definitions), it seems acceptable (or
even more aligned) to do the same for the set class metadata calls.
    @devversion
    devversion committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    53abb46 View commit details
    Browse the repository at this point in the history

  2. fixup! feat(compiler-cli): inline resources when generating class met… 

    …adata calls

Address feedback
    @devversion
    devversion committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    5c3fc58 View commit details
    Browse the repository at this point in the history