build: update to typescript 4.3.4 #42600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it format regression (angular#42022)" This reverts commit 71e14a7.
1 task
devversion
force-pushed
the
typescript-4.3.4
branch
from
eb35146
to
cd27e9b
Compare
devversion
added
action: review
josephperrott
approved these changes
Jun 18, 2021
| @@ -49,6 +49,6 @@ | |||
| "supertest": "^4.0.2", | |||
| "tslint": "^6.1.3", | |||
| "tslint-jasmine-noSkipOrFocus": "^1.0.9", | |||
| "typescript": "^4.3.2" | |||
| "typescript": "^4.3.4" | |||
There was a problem hiding this comment.
I know it won't matter a ton but can we do ~ here instead of ^ to match what we are doing in our other locations.
Alternatively we could do exact version as well.
There was a problem hiding this comment.
Yeah, let's just do it while being at it 👍
JoostK
approved these changes
Jun 18, 2021
Updates to TypeScript 4.3.4 which contains a fix for a printer regression that caused unexpected JavaScript output with our compiler transforms. See: microsoft/TypeScript#44070. Updates to TypeScript 4.3.4 which contains a fix for a printer
devversion
force-pushed
the
typescript-4.3.4
branch
from
3281ab1
to
597def7
Compare
gkalpak
approved these changes
Jun 19, 2021
JiaLiPassion
approved these changes
Jun 20, 2021
alan-agius4
added
action: merge
dylhunn
pushed a commit
that referenced
this pull request
Jun 21, 2021
Updates to TypeScript 4.3.4 which contains a fix for a printer regression that caused unexpected JavaScript output with our compiler transforms. See: microsoft/TypeScript#44070. Updates to TypeScript 4.3.4 which contains a fix for a printer PR Close #42600
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to TypeScript 4.3.4 which contains a fix for a printer
regression that caused unexpected JavaScript output with our
compiler transforms (and resulted in unexpected golden changes).
See: microsoft/TypeScript#44070.