Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@petebacondarwin fix(core): handle multiple i18n attributes with expression bindings (PATCH) #41912

Closed
wants to merge 1 commit into from
Closed

@petebacondarwin fix(core): handle multiple i18n attributes with expression bindings (PATCH) #41912

wants to merge 1 commit into from

Commits on May 1, 2021

  1. fix(core): handle multiple i18n attributes with expression bindings 

    When there are multiple attributes that are marked for i18n translation,
which contain expression bindings, we were generating i18n update op-codes
that did not accurately map to the correct value to be bound in the lView.
Each attribute's bindings were relative to the start of the lView first
attributes values rather than to their own.

This fix passes the current binding index to `generateBindingUpdateOpCodes()`
when processing i18n attributes to account for this.

Fixes angular#41869
    @petebacondarwin
    petebacondarwin committed May 1, 2021
    Copy the full SHA
    c343f00 View commit details
    Browse the repository at this point in the history