fix(core): handle multiple i18n attributes with expression bindings #41882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
action: review
petebacondarwin
added
the
target: patch
petebacondarwin
requested review from
mhevery and
AndrewKushnir
and removed request for
atscott
petebacondarwin
added
the
action: presubmit
crisbeto
reviewed
Apr 29, 2021
mhevery
added
the
action: cleanup
AndrewKushnir
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
@petebacondarwin thanks for fixing the issue and adding docs with perf assessment 👍
One comment that I have is that I'd like to propose adding a new test (or update an existing one to repro the issue) in packages/core/test/acceptance/i18n_spec.ts file as well, so we have better coverage there.
AndrewKushnir
removed
the
action: review
petebacondarwin
force-pushed
the
fw-i18n-opcodes-issue-41869
branch
from
3e0d8c4
to
5366d2a
Compare
petebacondarwin
removed
the
action: cleanup
@AndrewKushnir - I have added the acceptance test and now we are go for a presubmit |
AndrewKushnir
removed
the
action: presubmit
|
FYI presubmits are successful for the changes in this PR. |
AndrewKushnir
added
the
action: cleanup
When there are multiple attributes that are marked for i18n translation, which contain expression bindings, we were generating i18n update op-codes that did not accurately map to the correct value to be bound in the lView. Each attribute's bindings were relative to the start of the lView first attributes values rather than to their own. This fix passes the current binding index to `generateBindingUpdateOpCodes()` when processing i18n attributes to account for this. Fixes angular#41869
petebacondarwin
force-pushed
the
fw-i18n-opcodes-issue-41869
branch
from
5366d2a
to
ed4153c
Compare
petebacondarwin
added
action: merge
|
I rebased to clear the conflict. Only change was in a test file. So a new presubmit may not be necessary. |
crisbeto
approved these changes
Apr 30, 2021
mhevery
added
target: rc
mhevery
pushed a commit
that referenced
this pull request
Apr 30, 2021
…41882) When there are multiple attributes that are marked for i18n translation, which contain expression bindings, we were generating i18n update op-codes that did not accurately map to the correct value to be bound in the lView. Each attribute's bindings were relative to the start of the lView first attributes values rather than to their own. This fix passes the current binding index to `generateBindingUpdateOpCodes()` when processing i18n attributes to account for this. Fixes #41869 PR Close #41882
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple attributes that are marked for i18n translation,
which contain expression bindings, we were generating i18n update op-codes
that did not accurately map to the correct value to be bound in the lView.
Each attribute's bindings were relative to the start of the lView first
attributes values rather than to their own.
This fix passes the current binding index to
generateBindingUpdateOpCodes()when processing i18n attributes to account for this.
Fixes #41869