Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform-browser): update started state on reset #41608

Commits on May 25, 2021

  1. fix(platform-browser): update started state on reset

    This commit fixes the state of variable _started on call of reset method.
    
    Earlier behaviour was on call of `reset()` method we are not setting back
    `_started` flag's value to false and it created various issue for end user
    which were expecting this behaviour as per name of method.
    
    We provided end user `reset()` method, but it was empty method and on call
    of it wasn't doing anything. As end user/developer were not able to
    reuse animation not animation after call of reset method.
    
    In this PR on call of `reset()` method we are setting flag `_started` value to false
    which can be accessed by `hasStarted()`.
    
    Resolves angular#18140
    iRealNirmal authored and AndrewKushnir committed May 25, 2021
    Copy the full SHA
    c970d9c View commit details
    Browse the repository at this point in the history