Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support TypeScript 4.2 #41158

Closed
wants to merge 2 commits into from
Closed

feat(core): support TypeScript 4.2 #41158

wants to merge 2 commits into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 10, 2021 •
edited

Updates the repo to TypeScript 4.2 and tslib 2.1.0.

@google-cla google-cla bot added the cla: yes label Mar 10, 2021
@crisbeto crisbeto force-pushed the ts-4.2 branch 4 times, most recently from 73825ef to afafad5 Compare March 10, 2021 20:34
@jessicajaniuk jessicajaniuk added the area: core Issues related to the framework runtime label Mar 11, 2021
@ngbot ngbot bot added this to the Backlog milestone Mar 11, 2021
@Julien-Marcou
Copy link
Contributor

We should wait for the TypeScript team to back port this issue microsoft/TypeScript#43053 to the 4.2.X version of TypeScript (you can track the progress here : microsoft/TypeScript#43180)

The deprecation warnings given by TSLint + RxJS + TypeScript 4.2 can cause a lot of CI pipelines to break

@crisbeto crisbeto force-pushed the ts-4.2 branch 2 times, most recently from fe57424 to 6af2367 Compare March 13, 2021 16:00
@JoostK
Copy link
Member

JoostK commented Mar 13, 2021

Related PR that updates ngcc to be able to deal with TS4.2 generated libraries: #41201.

@crisbeto crisbeto force-pushed the ts-4.2 branch 3 times, most recently from 17acff1 to 53b02c1 Compare March 14, 2021 09:12
@crisbeto crisbeto marked this pull request as ready for review March 14, 2021 09:45
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release feature Issue that requests a new feature labels Mar 14, 2021
JoostK
JoostK reviewed Mar 14, 2021
View reviewed changes
integration/BUILD.bazel Outdated Show resolved Hide resolved
JiaLiPassion
JiaLiPassion approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Reviewed-for: zone.js

@alan-agius4
Copy link
Contributor

alan-agius4 commented Mar 15, 2021 •
edited

Typically in majors we drop support of earlier TS versions. Are we going to drop support for < 4.2 in a seperate PR?

AndrewKushnir
AndrewKushnir approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: fw-forms
Reviewed-for: fw-common

atscott
atscott approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-router

@pullapprove pullapprove bot requested a review from atscott March 15, 2021 19:30
atscott
atscott approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: language-service

@crisbeto crisbeto mentioned this pull request Mar 15, 2021
Closed
IgorMinar
IgorMinar approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline, please increase the lower limit for typescript support to 4.2.3 and delete the 4.0 typings tests. Let's keep the 4.1 typings tests for now while g3 is being updated.

otherwise lgtm. thank you!

Reviewed-for: global-approvers

packages/compiler-cli/src/typescript_support.ts Show resolved Hide resolved
packages/compiler-cli/package.json Outdated Show resolved Hide resolved
packages/bazel/package.json Outdated Show resolved Hide resolved
@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 16, 2021
JoostK
JoostK reviewed Mar 16, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@crisbeto
feat(core): support TypeScript 4.2
a141d54 
Updates the repo to TypeScript 4.2 and tslib 2.1.0.
@crisbeto
feat(core): drop support for TypeScript 4.0 and 4.1
727c275 
Drops support for TypeScript 4.0 and 4.1 across the repo.
The typings check for 4.1 was kept in order to ensure that we don't break g3.
alxhub
alxhub approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the compiler.

Changes for TCBs seem to be related to ts.Printer differences around casts, which shouldn't impact the behavior of TCBs.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 16, 2021
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir
Copy link
Contributor

FYI, presubmit is successful for the changes in this PR.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Mar 17, 2021
jessicajaniuk pushed a commit that referenced this pull request Mar 17, 2021
@crisbeto @thePunderWoman
feat(core): drop support for TypeScript 4.0 and 4.1 (#41158)
fa04894 
Drops support for TypeScript 4.0 and 4.1 across the repo.
The typings check for 4.1 was kept in order to ensure that we don't break g3.

PR Close #41158
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

@atscott atscott atscott approved these changes

@JiaLiPassion JiaLiPassion JiaLiPassion approved these changes

@alxhub alxhub alxhub approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes feature Issue that requests a new feature target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@crisbeto @Julien-Marcou @JoostK @alan-agius4 @AndrewKushnir @IgorMinar @atscott @JiaLiPassion @alxhub @jessicajaniuk