fix(core): Call onDestroy in production mode as well

[mhevery]

PR #39876 introduced an error where the onDestroy of ComponentRef would only get called if ngDevMode was set to true. This was because in dev mode we would freeze TCleanup to verify that no more static cleanup would get added to TCleanup array. This ensured that TCleanup was always present in dev mode. In production the TCleanup would get created only when needed. The resulting cleanup code was incorrectly indented and would only run if TCleanup was present causing this issue.

Fix #40105
## PR Checklist
Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[AndrewKushnir]

Thanks for the fix Misko! 👍

I have a couple more proposals that we can look into to avoid similar issues:

• rename getTViewCleanup and getLCleanup (to getOrCreateTViewCleanup and getOrCreateLViewCleanup respectively). This should highlight the fact that calling these methods might cause side effects.

• in the storeCleanupWithContext function itself, call freeze only when tView.cleanup is not null, i.e.:

    // If context is null that this is instance specific callback. These callbacks can only be
    // inserted after template shared instances. For this reason in ngDevMode we freeze the TView.
    if (ngDevMode && tView.cleanup !== null) {
      Object.freeze(tView.cleanup);
    }

What do you think?

[mhevery]

• rename getTViewCleanup and getLCleanup (to getOrCreateTViewCleanup and getOrCreateLViewCleanup respectively). This should highlight the fact that calling these methods might cause side effects.

DONE

• in the storeCleanupWithContext function itself, call freeze only when tView.cleanup is not null, i.e.:

Unfortunately, I can't do that. null is initial value meaning we can still add to it. So there is no way to distinguish nothing added yet, vs nothing added and no more adding is allowed.

[AndrewKushnir]

LGTM 👍 (just one minor comment)

[mhevery]

presubmit

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}