Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): unsubscribe from the onError when the root view is removed #39940

Closed
wants to merge 1 commit into from
Closed

fix(core): unsubscribe from the onError when the root view is removed #39940

wants to merge 1 commit into from

Commits on Dec 2, 2020

  1. fix(core): unsubscribe from the onError when the root view is removed 

    At the moment, when creating a root module, a subscription to the
`onError` subject is also created. It captures the scope where `NgModuleRef`
is created and prevents it from being garbage collected. Also note that this
`NgModuleRef` has a reference to the root module instance (e.g. `AppModule`),
which also prevents it from being GC'd.
    @arturovt
    arturovt committed Dec 2, 2020
    Copy the full SHA
    ef49c1c View commit details
    Browse the repository at this point in the history