Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): remove application from the testability registry when the root view is removed #39876

Closed
wants to merge 2 commits into from
Closed

fix(core): remove application from the testability registry when the root view is removed #39876

wants to merge 2 commits into from

Commits on Dec 1, 2020

  1. fix(core): remove application from the testability registry when the … 

    …root view is removed

In the new behavior Angular removes applications from the testability registry when the
root view gets destroyed. This eliminates a memory leak, because before that the
TestabilityRegistry holds references to HTML elements, thus they cannot be GCed.

PR Close #22106
    @arturovt @mhevery
    arturovt authored and mhevery committed Dec 1, 2020
    Copy the full SHA
    5d60525 View commit details
    Browse the repository at this point in the history

  2. test(core): verify onDestroy callbacks are invoked when ComponentRe… 

    …f is destroyed

This commit adds a few tests to verify that the `onDestroy` callbacks are invoked when `ComponentRef` instance
is destroyed and the logic is consistent between ViewEngine and Ivy.
    @AndrewKushnir
    AndrewKushnir committed Dec 1, 2020
    Copy the full SHA
    66e8d75 View commit details
    Browse the repository at this point in the history