Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): handle strings inside bindings that contain binding characters #39826

Closed
wants to merge 4 commits into from
Closed

fix(compiler): handle strings inside bindings that contain binding characters #39826

wants to merge 4 commits into from

Commits on Dec 8, 2020

  1. fix(compiler): handle strings inside bindings that contain binding ch… 

    …aracters

Currently the compiler treats something like `{{  '{{a}}' }}` as a nested
binding and throws an error, because it doesn't account for quotes
when it looks for binding characters. These changes add a bit of
logic to skip over text inside quotes when parsing.

Fixes angular#39601.
    @crisbeto
    crisbeto committed Dec 8, 2020
    Copy the full SHA
    c51bb46 View commit details
    Browse the repository at this point in the history

  2. fixup! fix(compiler): handle strings inside bindings that contain bin… 

    …ding characters
    @crisbeto
    crisbeto committed Dec 8, 2020
    Copy the full SHA
    3989b2f View commit details
    Browse the repository at this point in the history

  3. fixup! fix(compiler): handle strings inside bindings that contain bin… 

    …ding characters
    @crisbeto
    crisbeto committed Dec 8, 2020
    Copy the full SHA
    f56464e View commit details
    Browse the repository at this point in the history

  4. fixup! fix(compiler): handle strings inside bindings that contain bin… 

    …ding characters
    @crisbeto
    crisbeto committed Dec 8, 2020
    Copy the full SHA
    1a96c5e View commit details
    Browse the repository at this point in the history