Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(animations): replace copy of query selector node-list from "spread" to "for" #39646

Closed
wants to merge 1 commit into from
Closed

fix(animations): replace copy of query selector node-list from "spread" to "for" #39646

wants to merge 1 commit into from

Commits on Nov 25, 2020

  1. fix(animations): replace copy of query selector node-list from "sprea… 

    …d" to "for"

For element queries that return sufficiently large NodeList
objects, using spread syntax to populate the results array
causes a RangeError due to the call stack limit being reached.
This commit updates the code to use regular "for" loop instead.

Fixes angular#38551.
    @basherr
    basherr committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    ecab8ac View commit details
    Browse the repository at this point in the history