Revert "fix(elements): fire custom element output events during compo… #37525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds test case to cover a failure that was detected after merging angular#36302. That commit will be reverted and will need a new PR that does not cause this test to fail. PR Close angular#36699
This was originally fixed in angular#35976, but one of the window.scrollY assertions was missed. Also updated tests to use toBeGreater/LessThan to improve failure messages. PR Close angular#36742
…ns (angular#36661) Currently, when verifying our pullapprove configuration, we don't respect modifications to the set of files in a condition. e.g. It's not possible to do the following: ``` contains_any_globs(files.exclude(...), [ ``` This prevents us from having codeowner groups which match a directory, but want to filter out specific sub directories. For example, `fw-core` matches all files in the core package. We want to exclude the schematics from that glob. Usually we do this by another exclude condition. This has a *significant* downside though. It means that fw-core will not be requested if a PR changes schematic code, _and_ actual fw-core code. To support these conditions, the pullapprove verification tool is refactored, so that it no longer uses Regular expressions for parsing, but rather evaluates the code through a dynamic function. This is possible since the conditions are written in simple Python that can be run in NodeJS too (with small modifications/transformations). PR Close angular#36661
Adds a new codeowner group that is dedicated for changes to the migrations stored in `packages/core/schematics`. PR Close angular#36661
…r#36661) Currently, if changes are made to `compiler-cli/ngcc` and to other compiler-related files, then only the `fw-ngcc` group is requested for review. This is because the `not contains_any_globs` condition will be false for `fw-compiler` and the group will never become active. We fix this by removing the incorrect condition and filtering out ngcc files before checking `contains_any_globs` in the primary fw-compiler condition. PR Close angular#36661
…ar#36632) Previously, the commit message body regex only matched the first line of the body. This change corrects the regex to match the entire line. PR Close angular#36632
Enforces a requirement that all PR commit messages contain a body of at least 100 characters. This is meant to encourage commits within the repo to be more descriptive of each change. PR Close angular#36632
…angular#36434) * Move tools/brotli-cli, tools/browsers, tools/components, tools/ng_rollup_bundle, and modules/e2e_util to dev-infra/benchmarking * Fix imports and references to moved folders and files * Set up BUILD.bazel files for moved folders so they can be packaged with dev-infra's :npm_package PR Close angular#36434
* Set up dev-infra's :npm_package to also contain benchmarking suite * Add benchmarking deps to dev-infra's package.json * Add a bazel workspace to dev-infra's package.json. This is so that when a project wants to use dev-infra's code and macros, they can just import the macros from their node_modules instead of loading it separately PR Close angular#36434
…#36434) This change demonstrates how to use the newly created rule in one of our performance tests. Future commits and PRs will migrate the remaining tests to this new bazel rule. PR Close angular#36434
…ular#36791) Updating [angular#9.1.x](https://github.com/angular/angular/tree/9.1.x) from [cli-builds#9.1.x](https://github.com/angular/cli-builds/tree/9.1.x). ## Relevant changes in [commit range](angular/cli-builds@526c3cc...31ac613): **Modified** - help/analytics.json PR Close angular#36791
…ular#36783) After the user edits the file `core.d.ts`, the symbol from the core module will be invalided, which only is created when init the language service. Then the language-service will crash. PR Close angular#36783
…gular#36455) This change is part of a larger effort to migrate all golden type tracking files to a single location. Additionally, this makes it a bit easier to manage file ownership in pullapprove. PR Close angular#36455
…angular#36434)" (angular#36798) This reverts commit e6161ca. PR Close angular#36798
…lar#36434)" (angular#36798) This reverts commit d6f6cd0. PR Close angular#36798
…dev_infra (angular#36434)" (angular#36798) This reverts commit b7f2a03. PR Close angular#36798
…gular#36726) Previously we used gulp to run our formatter, currently clang-format, across our repository. This new tool within ng-dev allows us to migrate away from our gulp based solution as our gulp solution had issue with memory pressure and would cause OOM errors with too large of change sets. PR Close angular#36726
) Migrates away from gulp to ng-dev for running our formatter. Additionally, provides a deprecation warning for any attempted usage of the previous `gulp format:*` tasks. PR Close angular#36726
Correct typo in the router docs, changing "as your app growns" to "as your app grows". Previously the wrong spelling was used and this commit rectifies this. PR Close angular#36786
angular#35568) Prior to this change, animations-related runtime logic assumed that the @HostBinding and @HostListener with synthetic (animations) props are used for Components only. However having @HostBinding and @HostListener with synthetic props on Directives is also supported by View Engine. This commit updates the logic to select correct renderer to execute instructions (current renderer for Directives and sub-component renderer for Components). This PR resolves angular#35501. PR Close angular#35568
…#36825) Update rebase-pr script to properly reference a property on the refs object using `target` rather than the previously named `head`. PR Close angular#36825
This will allow the utilities in this file to be shared outside `translate` code. Some more text to get to the 100 character commit message requirement. PR Close angular#36834
angular#36834) Now the `SimpleJsonTranslationParser` will check that the format of the JSON is correct before agreeing to parse it. PR Close angular#36834
There was a lot of duplication and multiline backtick strings that made it hard to maintain. Some more text to ensure the commit message is long enough. PR Close angular#36834
…#36834) This commit moves the metadata around between the various interfaces to simplify and remove duplication. PR Close angular#36834
This commit removes some code that is not actually used. Some more text to ensure the commit message is long enough. PR Close angular#36834
…#36550) An enum declaration in TypeScript code will be emitted into JavaScript as a regular variable declaration, with the enum members being declared inside an IIFE. For ngcc to support interpreting such variable declarations as enum declarations with its members, ngcc needs to recognize the enum declaration emit structure and extract all member from the statements in the IIFE. This commit extends the `ConcreteDeclaration` structure in the `ReflectionHost` abstraction to be able to capture the enum members on a variable declaration, as a substitute for the original `ts.EnumDeclaration` as it existed in TypeScript code. The static interpreter has been extended to handle the extracted enum members as it would have done for `ts.EnumDeclaration`. Fixes angular#35584 Resolves FW-2069 PR Close angular#36550
…ar#36381) If there's an error during the first creation pass of a `TView`, the data structure may be corrupted which will cause framework assertion failures downstream which can mask the user's error. These changes add a new flag to the `TView` that indicates whether the first creation pass was successful, and if it wasn't we try re-create the `TView`. Fixes angular#31221. PR Close angular#36381
…ng system (angular#37232) Migrate the discover-new-conflicts tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close angular#37232
…ar#37232) Migrate the rebase tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close angular#37232
…ngular#37232) Migrate the pullapprove tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close angular#37232
…lar#37232) Migrate the ng-dev utils to use new logging system rather than directly calling console.* to create a better experience for users. PR Close angular#37232
…r#37232) Migrate the merge tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close angular#37232
…ging system (angular#37232) Migrate the ts-circular-dependencies tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close angular#37232
…lar#37232) Migrate the release tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close angular#37232
Update angular.io in support for #BlackLivesMatter. The PR updates the styles of the landing page and changes the current survey notification.
…y` type-casts This commit removes some unnecessary non-null assertions (`!`) and `as any` type-casts from the `elements` package.
…tialization Previously, event listeners for component output events attached on an Angular custom element before inserting it into the DOM (i.e. before instantiating the underlying component) didn't fire for events emitted during initialization lifecycle hooks, such as `ngAfterContentInit`, `ngAfterViewInit`, `ngOnChanges` (initial call) and `ngOnInit`. The reason was that that `NgElementImpl` [subscribed to events][1] _after_ calling [ngElementStrategy#connect()][2], which is where the [initial change detection][3] takes place (running the initialization lifecycle hooks). This commit fixes this by: 1. Ensuring `ComponentNgElementStrategy#events` is defined and available for subscribing to, even before instantiating the component. 2. Ensuring `NgElementImpl` subscribes to `NgElementStrategy#events` before calling `NgElementStrategy#connect()` (which initializes the component instance). Jira issue: [FW-2010](https://angular-team.atlassian.net/browse/FW-2010) [1]: https://github.com/angular/angular/blob/c0143cb2abdd172de1b95fd1d2c4cfc738640e28/packages/elements/src/create-custom-element.ts#L167-L170 [2]: https://github.com/angular/angular/blob/c0143cb2abdd172de1b95fd1d2c4cfc738640e28/packages/elements/src/create-custom-element.ts#L164 [3]: https://github.com/angular/angular/blob/c0143cb2abdd172de1b95fd1d2c4cfc738640e28/packages/elements/src/component-factory-strategy.ts#L158 Fixes angular#36141
…ngular#37399) Disabling Android 10 browser unit tests on Saucelabs due to errors. After remediation from Saucelabs to correct the discovered failures, this change can be reverted to renable the tests on Android 10. Example of failures seen: ``` 02 06 2020 14:03:05.048:INFO [SaucelabsLauncher]: Chrome 10.0 (Android) session at https://saucelabs.com/tests/54f5fb181db644a3b4779187c2309000 02 06 2020 14:03:06.869:INFO [Chrome Mobile 74.0.3729 (Android 0.0.0)]: Disconnected browser returned on socket E-bi0p0NKtghk-HcAAAO with id 85563367. Chrome Mobile 74.0.3729 (Android 0.0.0) ERROR: Error: XHR error loading http://angular-ci.local:9876/base/node_modules/rxjs/internal/operators/zip.js Error loading http://angular-ci.local:9876/base/node_modules/rxjs/internal/operators/zip.js as "../internal/operators/zip" from http://angular-ci.local:9876/base/node_modules/rxjs/operators/index.js Error: XHR error loading http://angular-ci.local:9876/base/node_modules/rxjs/internal/operators/zip.js at error (http://angular-ci.local:9876/base/node_modules/systemjs/dist/system.src.js?1c6a6c12fec50a8db7aeebe8e06e2b70135c0615:1028:16) at XMLHttpRequest.xhr.onreadystatechange [as __zone_symbol__ON_PROPERTYreadystatechange] (http://angular-ci.local:9876/base/node_modules/systemjs/dist/system.src.js?1c6a6c12fec50a8db7aeebe8e06e2b70135c0615:1036:13) at XMLHttpRequest.wrapFn (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:809:43) at ZoneDelegate.invokeTask (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:432:35) at Zone.runTask (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:201:55) at ZoneTask.invokeTask [as invoke] (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:514:38) at invokeTask (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:1722:18) at XMLHttpRequest.globalZoneAwareCallback (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:1748:21) ``` PR Close angular#37399
This commit will store a cached copy of the parsed tsconfig that can be reused if the tsconfig path is the same. This will improve the ngcc "noop" case, where there is no processing to do, when the entry-points have already been processed. Previously we were parsing this config every time we checked for entry-points to process, which can take up to seconds in some cases. Cherry-picked from angular#37417 (6e7bd93). Resolves angular#36882
atscott
added
the
target: lts
jelbourn
approved these changes
Jun 10, 2020
atscott
added
action: merge
…nent initialization" This reverts commit 454e073. This commit was found to cause some tests inside Google to fail.
atscott
force-pushed
the
revertelementslts
branch
from
428c4ef
to
dc9da17
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nent initialization (#36161)"
This reverts commit e9bff5f. Failures
were detected by Google tests after due to this commit.