Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Migrate TestBed.get to TestBed.inject #32382

Closed
wants to merge 1 commit into from
Closed

refactor(core): Migrate TestBed.get to TestBed.inject #32382

wants to merge 1 commit into from

Conversation

Goodwine
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Angular codebase uses TestBed.get

Issue Number: #26491

What is the new behavior?

Angular codebase uses TestBed.inject

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR depends on #32200 to be submitted

@Goodwine Goodwine requested review from a team as code owners August 28, 2019 23:44
@Goodwine Goodwine changed the title Testbed.inject.uses refactor(core): Migrate TestBed.get to TestBed.inject Aug 29, 2019
@mhevery mhevery self-assigned this Sep 3, 2019
@mhevery mhevery added the area: core Issues related to the framework runtime label Sep 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 3, 2019
@Goodwine
Copy link
Author

Goodwine commented Sep 5, 2019

@mhevery Couple unrelated changes are - AIO angular version was bumped to 9.0.0.next.5 from 8.0.0.next.1, and the bundle size check was updated, IIRC some changes should make the bundle smaller due to better treeshaking so I thought it was fine, can these be added together or should the version bump be a separate PR?

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 9, 2019
@mhevery
Copy link
Contributor

mhevery commented Sep 9, 2019

presubmit

@matsko matsko closed this in 9166baf Sep 9, 2019
@Goodwine Goodwine deleted the testbed.inject.uses branch September 9, 2019 23:15
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants