Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ngcc): handle compilation diagnostics #31996

Closed
wants to merge 2 commits into from
Closed

fix(ngcc): handle compilation diagnostics #31996

wants to merge 2 commits into from

Commits on Aug 29, 2019

  1. test(ivy): normalize rooted paths to include a drive letter in Windows 

    The Angular compiler has an emulation system for various kinds of
filesystems and runs its testcases for all those filesystems. This
allows to verify that the compiler behaves correctly in all of the
supported platforms, without needing to run the tests on the actual
platforms.

Previously, the emulated Windows mode would normalize rooted paths to
always include a drive letter, whereas the native mode did not perform
this normalization. The consequence of this discrepancy was that running
the tests in native Windows was behaving differently compared to how
emulated Windows mode behaves, potentially resulting in test failures
in native Windows that would succeed for emulated Windows.

This commit adds logic to ensure that paths are normalized equally for
emulated Windows and native Windows mode, therefore resolving the
discrepancy.
    @JoostK
    JoostK committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    200a70d View commit details
    Browse the repository at this point in the history

  2. fix(ngcc): handle compilation diagnostics 

    Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374
    @JoostK
    JoostK committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    504f500 View commit details
    Browse the repository at this point in the history