Breaking typed testbed get #30066
Closed
Breaking typed testbed get #30066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestBed.typedGet` is a non breaking change to make way for a typed `TestBed.get` signature. This commit adds the function with a different name and strong types. A future commit for Angular 9.x will replace the current `TestBed.get` signature with the one added here, and `TestBed.typedGet` will be then marked as deprecated to be completly removed on Angular 10.x `Injector.get` will match the same signature as `TestBed.typedGet` on Angular 9.x, both being breaking changes added at the same time. Issue #26491 Fixes #29905
14 tasks
|
@vikerman FYI |
benlesh
added
the
area: testing
TestBed.get no longer returns `any`, and `TestBed.typedGet` is now deprecated for Angular 9.x, It will eventually be removed, `TestBed.typedGet` can be directly renamed to `TestBed.get`. Fixes #26491 BREAKING CHANGE: - TestBed.get has been replaced by TestBed.typedGet so now it returns `T` instead of `any`. String providers are also no longer supported and now InjectionToken can be used, otherwise cast to `any` and receive a type `{}`. The untyped get was deprecated since 8.x - Injector#get deprecated signature that takes `any` tokens and returns `any` value has been removed, the signature was deprecated since 4.x
|
After discussing with Vikram, I'm closing this for #32200 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
TestBed.getreturnsanyTestBed.typedGetreturnsTInjector.getfor things not matchingType<T>|InjectionToken<T>returnanyIssue Number: N/A
What is the new behavior?
TestBed.getreturnsT(copy ofTestBed.typedGet)TestBed.typedGetis deprecatedInjector.getalso matchesTestBed.getsignature (i.e. now acceptsAbstractType<T>) and the deprecated signature has been deleted.String providers are no longer supported by the signature and need to be casted to
anyor migrated to an InjectionTokenDoes this PR introduce a breaking change?
Other information
This is supposed to follow after PR #30036, and this should be merged for 9.x assuming the mentioned PR was merged on 8.x