fix(core): fix memory leak on application reference destroy

[tmair]

When an application reference is destroyed it stays in memory because it is still registered in the testability registry.

Closes #22106, #13725

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When an application is destroyed the application still remains in memory because the testability registry still holds a reference to the application.

Issue Number: #22106, #13725

What is the new behavior?

When an application is destroyed it is also removed from the testability registry.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I have created a simple example application at https://github.com/tmair/angular-app-destroy
There are two commits, one using the current version of angular and the other one using the fixed version of angular

[vicb]

/ref #14819

[BenevidesLecontes]

I can confirm that this fix work. I was in trouble with memory leaks on IE, tried this fix and i saw performance increase.

[roni-frantchi]

This fix worked for me as well.
We saw a very clear and stable 20% improvement in execution time of our very (very) large test bed.

[wbhob]

Any update on this PR? It's been a few months but this looks like a good fix.

[abogartz]

Any update?

[ccchrisc]

How exactly do I test this? How do I rebuild my source with the updated angular file?

[allanalvarez]

Hi @PatNumainville
I'm trying to solve my issue about my app is 5x slower on IE compared to Chrome and Firefox. We all know IE sucks but I'm trying to optimize things as much as I can.

I'm using Angular 5 and I saw this PR. I was trying to find the packages/core/src/application_ref.ts but I could'not find it. Is this applicable in specific Angular version?

Thanks

[mikaelboff]

Any updates on this?

[mhevery]

already fixed in #39876

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}