refactor(core): private export token to disable fixture.detectChanges error
#55098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` error While we do want to discourage `fixture.detectChanges`, it is yet to be determined how this should be accomplished (warning, documentation, etc.). At the moment, not being able to disable the error at all is entirely prohibitive for existing test suites to use zoneless change detection in tests. We would much rather allow existing test suites to disable the error and use the zoneless change detection than prevent them from using it entirely until all the `detectChanges` calls have been fixed. Calling `detectChanges` manually can hide errors related to change detection timing, but it is even worse when the "PseudoApplication" fixture used (since it runs change detection _only_ on the component rather than through `ApplicationRef`).
atscott
added
the
area: testing
dylhunn
approved these changes
Mar 28, 2024
|
This PR was merged into the repository by commit edfc5a9. |
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
…s` error (angular#55098) While we do want to discourage `fixture.detectChanges`, it is yet to be determined how this should be accomplished (warning, documentation, etc.). At the moment, not being able to disable the error at all is entirely prohibitive for existing test suites to use zoneless change detection in tests. We would much rather allow existing test suites to disable the error and use the zoneless change detection than prevent them from using it entirely until all the `detectChanges` calls have been fixed. Calling `detectChanges` manually can hide errors related to change detection timing, but it is even worse when the "PseudoApplication" fixture used (since it runs change detection _only_ on the component rather than through `ApplicationRef`). PR Close angular#55098
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we do want to discourage
fixture.detectChanges, it is yet to be determined how this should be accomplished (warning, documentation, etc.). At the moment, not being able to disable the error at all is entirely prohibitive for existing test suites to use zoneless change detection in tests. We would much rather allow existing test suites to disable the error and use the zoneless change detection than prevent them from using it entirely until all thedetectChangescalls have been fixed. CallingdetectChangesmanually can hide errors related to change detection timing, but it is even worse when the "PseudoApplication" fixture used (since it runs change detection only on the component rather than throughApplicationRef).