New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add missing h1 to page for skip to main content on home page #55052
Conversation
Deployed adev-preview for 4135ae9 to: https://ng-dev-previews-fw--pr-angular-angular-55052-adev-prev-b0dvpu9q.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Clicking on the "skip to main button" still doesn't do anything for me with this change. |
5009a89
to
4135ae9
Compare
@JeanMeche Forgot to push another change. Let me know if it's still not working on your end! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR was merged into the repository by commit d63706e. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #53015
What is the new behavior?
Currently the skip-to-content button does not have an h1 element to jump to, so this PR should add a proper anchor for the skip to main content element.
Does this PR introduce a breaking change?
Other information