Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing h1 to page for skip to main content on home page #55052

Closed
wants to merge 1 commit into from

Conversation

bencodezen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #53015

What is the new behavior?

Currently the skip-to-content button does not have an h1 element to jump to, so this PR should add a proper anchor for the skip to main content element.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 26, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 26, 2024
@bencodezen bencodezen added adev: preview area: adev Angular.dev documentation action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 26, 2024
Copy link

github-actions bot commented Mar 26, 2024

Deployed adev-preview for 4135ae9 to: https://ng-dev-previews-fw--pr-angular-angular-55052-adev-prev-b0dvpu9q.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche
Copy link
Member

Clicking on the "skip to main button" still doesn't do anything for me with this change.

@bencodezen bencodezen force-pushed the 53015-add-h1-for-skip-to-main-content branch from 5009a89 to 4135ae9 Compare March 28, 2024 16:49
@bencodezen
Copy link
Contributor Author

@JeanMeche Forgot to push another change. Let me know if it's still not working on your end!

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 28, 2024
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atscott atscott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 28, 2024
@atscott
Copy link
Contributor

atscott commented Mar 28, 2024

This PR was merged into the repository by commit d63706e.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: adev Angular.dev documentation area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip to Main Content Does not work creating severe accessibility issues
3 participants