Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to Main Content Does not work creating severe accessibility issues #53015

Closed
stot3 opened this issue Nov 17, 2023 · 10 comments
Closed

Skip to Main Content Does not work creating severe accessibility issues #53015

stot3 opened this issue Nov 17, 2023 · 10 comments
Labels
area: adev Angular.dev documentation area: docs-infra Angular.dev application and infrastructure help wanted An issue that is suitable for a community contributor (based on its complexity/scope). P2 The issue is important to a large percentage of users, with a workaround
Projects
Milestone

Comments

@stot3
Copy link

stot3 commented Nov 17, 2023

Describe the problem that you experienced

Clicking the Skip to Main Content Button does not skip to main content.

Enter the URL of the topic with the problem

http://angular.dev

Describe what you were looking for in the documentation

The skip to main content button should skip to the first non-repeated element.

Describe the actions that led you to experience the problem

Clicking the skip to content button.

Describe what you want to experience that would fix the problem

The skip to main content button should skip to the first non-repeated element.

Add a screenshot if that helps illustrate the problem

No response

If this problem caused an exception or error, please paste it here

No response

If the problem is browser-specific, please specify the device, OS, browser, and version

No response

Provide any additional information here in as much as detail as you can

No response

@JeanMeche JeanMeche added the area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) label Nov 24, 2023
@ngbot ngbot bot added this to the needsTriage milestone Nov 24, 2023
@JeanMeche JeanMeche added area: docs-infra Angular.dev application and infrastructure and removed area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Nov 24, 2023
@twerske twerske added area: adev Angular.dev documentation P2 The issue is important to a large percentage of users, with a workaround labels Nov 29, 2023
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 29, 2023
@twerske twerske added the help wanted An issue that is suitable for a community contributor (based on its complexity/scope). label Nov 29, 2023
@twerske
Copy link
Contributor

twerske commented Nov 29, 2023

Thanks for the report! Once the app is buildable I'd love to review a PR for contributors interested here!

@danieljancar
Copy link
Contributor

Hey @twerske,
Is there an update on what challenges are blocking this issue? How can I assist in expediting the process? Thanks 😄

@JeanMeche
Copy link
Member

The team still need to integrate the adev site into the build process ! The app isn't runnable locally until this has been done.

@mgechev mgechev added this to To do in adev Feb 1, 2024
@JeanMeche
Copy link
Member

I did take a look at it, the button works fine but has no purpose on the home page. There is no content to focus on.

Or maybe we should focus on the editor ?

@bencodezen bencodezen moved this from To Do to In Progress in adev Mar 25, 2024
@bencodezen
Copy link
Contributor

@JeanMeche Agreed on your findings. Instead of the editor, what do you think of having it focus on the "Learn Angular" button which is where we primarily want people to go?

@stot3
Copy link
Author

stot3 commented Mar 25, 2024 via email

@stot3
Copy link
Author

stot3 commented Mar 25, 2024 via email

@bencodezen
Copy link
Contributor

@stot3 I took a look at the code and it seems like the issue is that the button looks for an H1 and there doesn't seem to be on the home page. I'll try and dive deeper to see what we can do to allow users to go to content.

@bencodezen bencodezen linked a pull request Mar 26, 2024 that will close this issue
14 tasks
@bencodezen bencodezen moved this from In Progress to Review / Queue in adev Mar 26, 2024
@bencodezen bencodezen moved this from Review / Queue to Done in adev Apr 22, 2024
@bencodezen
Copy link
Contributor

Closed via #55052

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: adev Angular.dev documentation area: docs-infra Angular.dev application and infrastructure help wanted An issue that is suitable for a community contributor (based on its complexity/scope). P2 The issue is important to a large percentage of users, with a workaround
Projects
adev
Done
Development

Successfully merging a pull request may close this issue.

5 participants