-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add missing info about a component in the "pipe could not be found" error message #44081
fix(core): add missing info about a component in the "pipe could not be found" error message #44081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohan-pednekar thanks for creating this PR! Please see comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @rohan-pednekar. The changes look good and we are very close to landing this PR! There are few remaining items:
- I've left a comment to move a whitespace in the error message, please have a look
- We'd need all commits to be merged into one and let's call it
fix(core): add missing info about a component in the "pipe could not be found" error message
instead offeat(core): ...
- The "lint" CI job indicates that one of the files requires formatting. Could you please rebase this PR on top of the latest master and run the command from the "lint" CI job?
- The
legacy-unit-tests-saucelabs
fails for unrelated reasons: it uses old JIT compiler, thus the error message is different. We are working on fixing that, so there are no extra fixes are needed in this PR to solve that.
Thank you.
Sure. I'll add all the suggested changes. Thank you @AndrewKushnir |
b1e3ce2
to
c66b3c7
Compare
FYI this PR is blocked by #43884 (the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohan-pednekar thanks for the updates, the changes look good 👍
I've started tests in Google's codebase and will let you know if there are any issues.
Thank you @AndrewKushnir |
…be found" error message Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle.
c66b3c7
to
32fc310
Compare
@rohan-pednekar FYI, this PR is now unblocked (after landing #43884) and I've rebased it on top of the most recent version of the master branch. The tests in Google's codebase went well, so the only remaining step is to get one more review. I will take care of it and let you know. Thank you. |
Sure. Thank you @AndrewKushnir 👍😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍪
This PR was merged into the repository by commit b06e398. |
@rohan-pednekar just want to let you know that your PR was merged and the change will be available as a part of the v13.0.3 release (likely next week). Thanks for contributing to Angular! 👍 |
Wow! 😍 Without your help and support, this would not have been possible. Thank you once again @AndrewKushnir ❤. |
Also thanks to @jessicajaniuk, @splincode 👍😊 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…be found" error message (angular#44081) Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle. PR Close angular#44081
Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 43855
What is the new behavior?
Before
Currently Angular throws the following error message at runtime when a pipe can not be found. However there is no information on which component has this problem, which makes debugging harder.
After
Add error message for pipe with component class name in which it has a problem.
Does this PR introduce a breaking change?
Other information