fix(common): add right ContentType for boolean values with HttpClient request body(#38924) #41885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopal-jayaraman
force-pushed
the
gopj-content-type
branch
from
189005f
to
97f144d
Compare
petebacondarwin
approved these changes
Apr 29, 2021
3 tasks
gopal-jayaraman
force-pushed
the
gopj-content-type
branch
2 times, most recently
from
f76484a
to
d1bee36
Compare
alfaproject
reviewed
Apr 30, 2021
packages/common/http/src/request.ts
Outdated
| @@ -324,7 +324,7 @@ export class HttpRequest<T> { | |||
| } | |||
| // Arrays, objects, and numbers will be encoded as JSON. | |||
| if (typeof this.body === 'object' || typeof this.body === 'number' || | |||
| Array.isArray(this.body)) { | |||
| typeof this.body === 'boolean' || Array.isArray(this.body)) { | |||
There was a problem hiding this comment.
Array.isArray is redundant because this.body is an object in that case
There was a problem hiding this comment.
P.S.: Update the comment in line 325
There was a problem hiding this comment.
@alfaproject - I have updated the review comments, Please check.
… request body(angular#38924) currently a boolean as body is seen as text/plain, where is should be seen as application/json, since it is valid JSON, like numbers.
gopal-jayaraman
force-pushed
the
gopj-content-type
branch
from
d1bee36
to
1cb2bdb
Compare
petebacondarwin
added
action: presubmit
|
@petebacondarwin FYI presubmits are successful for the changes in this PR. |
AndrewKushnir
removed
the
action: presubmit
petebacondarwin
added
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding application/json as ContentType for boolean as the body, currently it is seen as text/plain, where it should be seen as application/json, since it is valid JSON, like numbers.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
currently a boolean as the body is seen as text/plain, where it should be seen as application/json, since it is valid JSON, like numbers.
Issue Number: #38924
What is the new behavior?
currently a boolean as the body is seen as text/plain, where it should be seen as application/json, since it is valid JSON, like numbers.
Does this PR introduce a breaking change?
Other information