Skip to content

Commit

Permalink
fix(common): add right ContentType for boolean values with HttpClient…
Browse files Browse the repository at this point in the history
… request body(#38924) (#41885)

currently a boolean as body is seen as text/plain, where is should be seen as application/json, since it is valid JSON, like numbers.

PR Close #41885
  • Loading branch information
gopal-jayaraman authored and mhevery committed May 3, 2021
1 parent 7e9ef4d commit ae0fa08
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/common/http/src/request.ts
Expand Up @@ -300,9 +300,9 @@ export class HttpRequest<T> {
if (this.body instanceof HttpParams) {
return 'application/x-www-form-urlencoded;charset=UTF-8';
}
// Arrays, objects, and numbers will be encoded as JSON.
// Arrays, objects, boolean and numbers will be encoded as JSON.
if (typeof this.body === 'object' || typeof this.body === 'number' ||
Array.isArray(this.body)) {
typeof this.body === 'boolean') {
return 'application/json';
}
// No type could be inferred.
Expand Down
4 changes: 4 additions & 0 deletions packages/common/http/test/request_spec.ts
Expand Up @@ -115,6 +115,10 @@ const TEST_STRING = `I'm a body!`;
const req = baseReq.clone({body: {data: 'test data'}});
expect(req.detectContentTypeHeader()).toBe('application/json');
});
it('handles boolean as json', () => {
const req = baseReq.clone({body: true});
expect(req.detectContentTypeHeader()).toBe('application/json');
});
});
describe('body serialization', () => {
const baseReq = new HttpRequest('POST', '/test', null);
Expand Down

0 comments on commit ae0fa08

Please sign in to comment.