fix(localize): render correct closing tag placeholder names in XLIFF 2 #41152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are elements in a translated message, the start and end tags are encoded as placeholders. The names of these placeholders are computed from the name of the element. For example `<a> will be `START_LINK` and `</a>` will be `CLOSE_LINK`. If there are more than one element with the same name, but different attributes, then the starting placeholder name is made unique. For example `<a href="a">` would be `START_LINK`, while `<a href="b">` in the same message would then be called `START_LINK_1`. But the closing tags will not be made unique since there are no attrbutes; the always have the same text `</a>`, which will produce, for example, `CLOSE_LINK`. Previously, when extracting XLIFF 2 formatted translation files, the closing tag placeholder names were computed incorrectly from the opening tag placeholder names. For example `CLOSE_LINK_1`. This commit strips these `_1` type endings from the start tag placeholder name when computing the closing tag placeholder name. It also ensures that the `type` of the placeholder is computed accurately in these cases too. Fixes angular#41142
petebacondarwin
added
action: review
AndrewKushnir
approved these changes
Mar 10, 2021
AndrewKushnir
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 10, 2021
#41152) When there are elements in a translated message, the start and end tags are encoded as placeholders. The names of these placeholders are computed from the name of the element. For example `<a> will be `START_LINK` and `</a>` will be `CLOSE_LINK`. If there are more than one element with the same name, but different attributes, then the starting placeholder name is made unique. For example `<a href="a">` would be `START_LINK`, while `<a href="b">` in the same message would then be called `START_LINK_1`. But the closing tags will not be made unique since there are no attrbutes; the always have the same text `</a>`, which will produce, for example, `CLOSE_LINK`. Previously, when extracting XLIFF 2 formatted translation files, the closing tag placeholder names were computed incorrectly from the opening tag placeholder names. For example `CLOSE_LINK_1`. This commit strips these `_1` type endings from the start tag placeholder name when computing the closing tag placeholder name. It also ensures that the `type` of the placeholder is computed accurately in these cases too. Fixes #41142 PR Close #41152
This was referenced Mar 17, 2021
Merged
Closed
This was referenced Mar 18, 2021
Closed
Merged
Closed
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are elements in a translated message, the start and end tags
are encoded as placeholders. The names of these placeholders are computed
from the name of the element. For example
<a> will beSTART_LINKandwill beCLOSE_LINK`.If there are more than one element with the same name, but different attributes,
then the starting placeholder name is made unique.
For example
<a href="a">would beSTART_LINK, while<a href="b">inthe same message would then be called
START_LINK_1.But the closing tags will not be made unique since there are no attrbutes;
the always have the same text
</a>, which will produce, for example,CLOSE_LINK.Previously, when extracting XLIFF 2 formatted translation files, the closing
tag placeholder names were computed incorrectly from the opening tag
placeholder names. For example
CLOSE_LINK_1.This commit strips these
_1type endings from the start tag placeholdername when computing the closing tag placeholder name. It also ensures
that the
typeof the placeholder is computed accurately in these casestoo.
Fixes #41142