fix(compiler): generate relative paths only in summary file errors #26759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously errors in the summary file would include absolute file names. This is undesirable as the output of a build should not depend on the current working directory. Doing so causes nondeterminism issues in builds.
|
You can preview 08df043 at https://pr26759-08df043.ngbuilds.io/. |
vikerman
approved these changes
Oct 26, 2018
alxhub
added
action: merge
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
…ngular#26759) Previously errors in the summary file would include absolute file names. This is undesirable as the output of a build should not depend on the current working directory. Doing so causes nondeterminism issues in builds. PR Close angular#26759
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…ngular#26759) Previously errors in the summary file would include absolute file names. This is undesirable as the output of a build should not depend on the current working directory. Doing so causes nondeterminism issues in builds. PR Close angular#26759
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously errors in the summary file would include absolute file names.
This is undesirable as the output of a build should not depend on the
current working directory. Doing so causes nondeterminism issues in
builds.