Incorrect error message: Could not resolve /my/missing/import relative to [object Object]

[dejoean]

🐞 bug report

Affected Package

The issue is caused by package @angular/compiler

Is this a regression?

Yes, the previous version in which this bug was not present was: prior to pull 26759

Description

On line 423-424 in static_symbol_resolver in pull 26759 the following line was changed to call self.host.getMetadataFor on the filepath. This change causes the returned value to be an object, which is then inserted into the template string, producing the output [object Object].

message:
  `Could not resolve ${module} relative to ${self.host.getMetadataFor(sourceSymbol.filePath)}.`,

On a separate note the period at the end of the statement is duplicated when it is logged out so it could be removed here.

🔬 Minimal Reproduction

Can be reproduced by forcing the relevant error to be thrown, or simply taking the template string provided and passing it any object type where self.host.getMetadataFor(sourceSymbol.filePath) is.

🔥 Exception or Error

Could not resolve /my/missing/import relative to [object Object]

🌍 Your Environment

Angular Version: 8.1.0-beta.0

Anything else relevant? Google Environment

[alxhub]

Hello @joe-denea,

Thank you for tracking down the PR which caused this. Can you also include a reproduction - a repository with code that produces the error, and instructions on how to run the build? Without a reproduction it's difficult for us to both identify the issue and to verify that it's fixed.

[dejoean]

Hey @alxhub

I already identified the issue in the actual code. getMetaDataFor returns an object type and that return value is being directly inserted into an ES6 template literal, producing the output [object Object]. Any object inserted into a template literal will produce this output and thus any return value generated by getMetaDataFor will produce this output. There is nothing else I could make clear by creating a repro repository, the entire issue is that `${{}}` = '[object Object]' so the code I referenced is fundamentally incorrect. Likely the intent was to access a particular property of the returned metadata object to get a relative path or something. You might have a better idea what the intent was since you wrote the PR in question.

[alxhub]

@joe-denea

Likely the intent was to call self.host.getOutputName instead of self.host.getMetadataFor.

Given that this is in View Engine code, I'm inclined to close this as the metadata system is going away in its entirety with Ivy, and without a reproduction demonstrating the issue it would take me too long to develop a test for the admittedly trivial fix.

[petebacondarwin]

Closing due to a lack of reproduction, and also since it only affects the deprecated ViewEngine compiler mode.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}