New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APP_INITIALIZER should also work with observables #15088
Comments
2 years later. |
hmmmmmmmmmmmmm :D what's the status? |
This still doesn't seem to work at all 0_0 |
2 and a half years later |
I have opened a PR to fix this issue, anyone could check it? |
User expected this to work: https://stackoverflow.com/questions/47422095/angular-app-initializer-promise-vs-observable |
add support to observable with APP_INITIALIZER close angular#15088
add support to observable with APP_INITIALIZER close angular#15088
3 years later |
add support to observable with APP_INITIALIZER close angular#15088
add support to observable with APP_INITIALIZER close angular#15088 feat(core): add rxjs deprecated note Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com> feat(core): fix code style Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com> test(core): add more test for observables initializer feat(core): add more test for observables initializer
add support to observable with APP_INITIALIZER close angular#15088 Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
add support to observable with APP_INITIALIZER close angular#15088 Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
add support to observable with APP_INITIALIZER close angular#15088 Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
add support to observable with APP_INITIALIZER close angular#15088 Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com> Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
add support to observable with APP_INITIALIZER close angular#15088 Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com> Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
add support to observable with APP_INITIALIZER close angular#15088 Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com> Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
This commit adds support for Observables that now can be used as a part of APP_INITIALIZER. Previously, only Primises were supported. Closes angular#15088.
Hi, just want to give a quick update: the Thanks @vthinkxie for implementing this feature 👍 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a ... (check one with "x")
Current behavior
APP_INITIALIZER only works with promises.
Expected behavior
Should also work with observables
What is the motivation / use case for changing the behavior?
Consistency with other parts of the framework
The text was updated successfully, but these errors were encountered: