Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP_INITIALIZER should also work with observables #15088

Closed
DzmitryShylovich opened this issue Mar 11, 2017 · 9 comments · Fixed by ngstack/translate#644
Closed

APP_INITIALIZER should also work with observables #15088

DzmitryShylovich opened this issue Mar 11, 2017 · 9 comments · Fixed by ngstack/translate#644
Labels
area: core Issues related to the framework runtime core: bootstrap feature Issue that requests a new feature
Milestone

Comments

@DzmitryShylovich
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] feature request

Current behavior
APP_INITIALIZER only works with promises.

Expected behavior
Should also work with observables

What is the motivation / use case for changing the behavior?
Consistency with other parts of the framework

DzmitryShylovich added a commit to DzmitryShylovich/angular that referenced this issue Mar 12, 2017
DzmitryShylovich added a commit to DzmitryShylovich/angular that referenced this issue Mar 12, 2017
@IgorMinar IgorMinar added area: core Issues related to the framework runtime feature Issue that requests a new feature labels Mar 14, 2017
@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2018
@nukec
Copy link

nukec commented Feb 12, 2019

2 years later.

@TheAifam5
Copy link

hmmmmmmmmmmmmm :D what's the status?

@hevans90
Copy link

This still doesn't seem to work at all 0_0

@johnsnow20087349
Copy link

2 and a half years later

vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
@vthinkxie
Copy link
Contributor

I have opened a PR to fix this issue, anyone could check it?
#33222

@pauldraper
Copy link
Contributor

vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Sep 14, 2020
add support to observable with APP_INITIALIZER

close angular#15088
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Sep 14, 2020
add support to observable with APP_INITIALIZER

close angular#15088
@Leonardo-Olivo
Copy link

3 years later

vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Feb 5, 2021
add support to observable with APP_INITIALIZER

close angular#15088
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Feb 7, 2021
add support to observable with APP_INITIALIZER

close angular#15088

feat(core): add rxjs deprecated note

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

feat(core): fix code style

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

test(core): add more test for observables initializer

feat(core): add more test for observables initializer
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Feb 9, 2021
add support to observable with APP_INITIALIZER

close angular#15088

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Feb 9, 2021
add support to observable with APP_INITIALIZER

close angular#15088

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Feb 10, 2021
add support to observable with APP_INITIALIZER

close angular#15088

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Feb 10, 2021
add support to observable with APP_INITIALIZER

close angular#15088

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Feb 10, 2021
add support to observable with APP_INITIALIZER

close angular#15088

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
vthinkxie pushed a commit to vthinkxie/angular that referenced this issue Feb 10, 2021
add support to observable with APP_INITIALIZER

close angular#15088

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
AndrewKushnir pushed a commit to vthinkxie/angular that referenced this issue Feb 19, 2021
This commit adds support for Observables that now can be used as a part of APP_INITIALIZER. Previously, only
Primises were supported.

Closes angular#15088.
@AndrewKushnir
Copy link
Contributor

Hi, just want to give a quick update: the APP_INITIALIZER-related logic was extended (see PR #33222) to also support observables. The change would be available in a few weeks as a part of v12 release.

Thanks @vthinkxie for implementing this feature 👍

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.