Skip to content

Commit

Permalink
fixup! fix(core): hardening attribute and property binding rules for …
Browse files Browse the repository at this point in the history
…<iframe> elements
  • Loading branch information
AndrewKushnir committed Nov 12, 2022
1 parent 0ebb493 commit b69531f
Showing 1 changed file with 0 additions and 38 deletions.
38 changes: 0 additions & 38 deletions packages/core/test/acceptance/security_spec.ts
Expand Up @@ -176,25 +176,6 @@ describe('iframe processing', () => {
expectIframeCreationToFail(IframeComp);
});

it(`should error when a security-sensitive attribute is applied ` +
`using a property binding (checking \`${securityAttr}\`, making ` +
`sure it's case-insensitive)`,
() => {
@Component({
selector: 'my-comp',
template: `
<iframe
${srcAttr}="${TEST_IFRAME_URL}"
[${securityAttr.toUpperCase()}]="''"
></iframe>
`,
})
class IframeComp {
}

expectIframeCreationToFail(IframeComp);
});

it(`should error when a security-sensitive attribute is applied ` +
`using a property binding (checking \`${securityAttr}\`)`,
() => {
Expand All @@ -213,25 +194,6 @@ describe('iframe processing', () => {
expectIframeCreationToFail(IframeComp);
});

it(`should error when a security-sensitive attribute is applied ` +
`using a property binding (checking \`${securityAttr}\`, making ` +
`sure it's case-insensitive)`,
() => {
@Component({
selector: 'my-comp',
template: `
<iframe
${srcAttr}="${TEST_IFRAME_URL}"
[attr.${securityAttr.toUpperCase()}]="''"
></iframe>
`,
})
class IframeComp {
}

expectIframeCreationToFail(IframeComp);
});

it(`should allow changing \`${srcAttr}\` after initial render`, () => {
@Component({
selector: 'my-comp',
Expand Down

0 comments on commit b69531f

Please sign in to comment.