Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
reactor(compiler-cli): account for babel types change
This commit accounts for the Babel types changes. Some properties can now also be `undefined` so existing checks/assertions had to be adjusted to also capture `undefined` (along with `null`). Additionally, in preparation for a new ECMA proposal, Babel types seem to have been updated to include private names in object property keys. This is not necessarily the case for object expressions, but could be for object patterns (in the future -- when implemented). More details: babel/babel#14304 and https://github.com/tc39/proposal-destructuring-private.
- Loading branch information
1 parent
cace1b0
commit 99601f7
Showing
9 changed files
with
22 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...r-cli/test/compliance/test_cases/source_mapping/inline_templates/ng_for_simple_partial.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...li/test/compliance/test_cases/source_mapping/inline_templates/ng_for_templated_partial.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...er-cli/test/compliance/test_cases/source_mapping/inline_templates/ng_if_simple_partial.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...cli/test/compliance/test_cases/source_mapping/inline_templates/ng_if_templated_partial.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
.ɵɵelementStart(0, "div");\n // SOURCE: "/ng_if_templated.ts" "<div>" | ||
.ɵɵelementStart(0, "div");\n // SOURCE: "/ng_if_templated.ts" "<div>" | ||
… | ||
// TODO - map the bindings better | ||
// TODO: Work out how to fix the broken segment for the last item in a template | ||
.ɵɵelementEnd();\n // SOURCE: "/ng_if_templated.ts" "</div>\n" | ||
.ɵɵelementEnd();\n // SOURCE: "/ng_if_templated.ts" "</div>\n" | ||
… | ||
// TODO: the `ctx_r...` appears to be dependent upon previous tests!!! | ||
// TODO: expectMapping(mappings, { source: '{{ name }}', generated: 'i0.ɵɵtextInterpolate(ctx_r0.name)', sourceUrl: '../ng_if_templated.ts'}); |
2 changes: 1 addition & 1 deletion
2
...t/compliance/test_cases/source_mapping/inline_templates/output_binding_complex_partial.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...st/compliance/test_cases/source_mapping/inline_templates/output_binding_simple_partial.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...compliance/test_cases/source_mapping/inline_templates/two_way_binding_longhand_partial.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
.ɵɵelementStart(1, "input", 0) // SOURCE: "/two_way_binding_longhand.ts" "<input " | ||
… | ||
// TODO: improve mappings here | ||
.ɵɵlistener("ngModelChange", function TestCmp_Template_input_ngModelChange_1_listener($event) {\n // SOURCE: "/two_way_binding_longhand.ts" "bindon-ngModel=\"name\">'" | ||
.ɵɵlistener("ngModelChange", function TestCmp_Template_input_ngModelChange_1_listener($event) {\n // SOURCE: "/two_way_binding_longhand.ts" "bindon-ngModel=\"name\">'" | ||
… | ||
// TODO: Work out how to fix the broken segment for the last item in a template | ||
.ɵɵelementEnd() // SOURCE: "/two_way_binding_longhand.ts" "<input " |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters