feat(compiler): allow trailing comma in array literal (#22277)

Allows `[1, 2, ]` syntax in angular expressions. closes #20773 PR Close #22277
angular · Dec 2, 2020 · 8d613c1 · 8d613c1
1 parent efd0d33
commit 8d613c1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/compiler/src/expression_parser/parser.ts b/packages/compiler/src/expression_parser/parser.ts
@@ -820,11 +820,14 @@ export class _ParseAST {
 
   parseExpressionList(terminator: number): AST[] {
     const result: AST[] = [];
-    if (!this.next.isCharacter(terminator)) {
-      do {
+
+    do {
+      if (!this.next.isCharacter(terminator)) {
         result.push(this.parsePipe());
-      } while (this.consumeOptionalCharacter(chars.$COMMA));
-    }
+      } else {
+        break;
+      }
+    } while (this.consumeOptionalCharacter(chars.$COMMA));
     return result;
   }
 

diff --git a/packages/compiler/test/expression_parser/parser_spec.ts b/packages/compiler/test/expression_parser/parser_spec.ts
@@ -106,6 +106,7 @@ describe('parser', () => {
         checkAction('[]');
         checkAction('[].length');
         checkAction('[1, 2].length');
+        checkAction('[1, 2,]', '[1, 2]');
       });
 
       it('should parse map', () => {